Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 1019593002: Remove work around for AppCompat switch thumb issues (Closed)

Created:
5 years, 9 months ago by Theresa
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove work around for AppCompat switch thumb issues Original work around done in: crbug.com/455327 and crbug.com/459782 BUG=440601 Committed: https://crrev.com/821dbcff61cfb0ab1d602ef505b9545599a86410 Cr-Commit-Position: refs/heads/master@{#321385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -53 lines) Patch
D chrome/android/java/res/color/switch_thumb_tint.xml View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_switch_to_on_mtrl_00001.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_switch_to_on_mtrl_00012.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_switch_to_on_mtrl_00001.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_switch_to_on_mtrl_00012.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_switch_to_on_mtrl_00001.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_switch_to_on_mtrl_00012.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_switch_to_on_mtrl_00001.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_switch_to_on_mtrl_00012.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_switch_to_on_mtrl_00001.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_switch_to_on_mtrl_00012.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/switch_thumb.xml View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/ChromeSwitchCompat.java View 3 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Theresa
5 years, 9 months ago (2015-03-18 19:42:13 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 9 months ago (2015-03-18 20:05:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019593002/1
5 years, 9 months ago (2015-03-18 20:25:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/50571)
5 years, 9 months ago (2015-03-18 21:04:08 UTC) #7
Theresa
newt@ ptal - I need at lgtm from an owner
5 years, 9 months ago (2015-03-19 13:43:47 UTC) #9
newt (away)
lgtm
5 years, 9 months ago (2015-03-19 17:15:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019593002/1
5 years, 9 months ago (2015-03-19 17:15:48 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 17:20:12 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 17:20:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/821dbcff61cfb0ab1d602ef505b9545599a86410
Cr-Commit-Position: refs/heads/master@{#321385}

Powered by Google App Engine
This is Rietveld 408576698