Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: src/ic/arm64/handler-compiler-arm64.cc

Issue 1019563002: Load from PropertyCells using PropertyCell::kValueOffset rather than Cell::kValueOffset (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm/handler-compiler-arm.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 Label miss; 338 Label miss;
339 if (IC::ICUseVector(kind())) { 339 if (IC::ICUseVector(kind())) {
340 PushVectorAndSlot(); 340 PushVectorAndSlot();
341 } 341 }
342 FrontendHeader(receiver(), name, &miss); 342 FrontendHeader(receiver(), name, &miss);
343 343
344 // Get the value from the cell. 344 // Get the value from the cell.
345 Register result = StoreDescriptor::ValueRegister(); 345 Register result = StoreDescriptor::ValueRegister();
346 Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell); 346 Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell);
347 __ LoadWeakValue(result, weak_cell, &miss); 347 __ LoadWeakValue(result, weak_cell, &miss);
348 __ Ldr(result, FieldMemOperand(result, Cell::kValueOffset)); 348 __ Ldr(result, FieldMemOperand(result, PropertyCell::kValueOffset));
349 349
350 // Check for deleted property if property can actually be deleted. 350 // Check for deleted property if property can actually be deleted.
351 if (is_configurable) { 351 if (is_configurable) {
352 __ JumpIfRoot(result, Heap::kTheHoleValueRootIndex, &miss); 352 __ JumpIfRoot(result, Heap::kTheHoleValueRootIndex, &miss);
353 } 353 }
354 354
355 Counters* counters = isolate()->counters(); 355 Counters* counters = isolate()->counters();
356 __ IncrementCounter(counters->named_load_global_stub(), 1, x1, x3); 356 __ IncrementCounter(counters->named_load_global_stub(), 1, x1, x3);
357 if (IC::ICUseVector(kind())) { 357 if (IC::ICUseVector(kind())) {
358 DiscardVectorAndSlot(); 358 DiscardVectorAndSlot();
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
761 // Return the generated code. 761 // Return the generated code.
762 return GetCode(kind(), Code::FAST, name); 762 return GetCode(kind(), Code::FAST, name);
763 } 763 }
764 764
765 765
766 #undef __ 766 #undef __
767 } 767 }
768 } // namespace v8::internal 768 } // namespace v8::internal
769 769
770 #endif // V8_TARGET_ARCH_IA32 770 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/arm/handler-compiler-arm.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698