Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1019533002: [DevTools] Cleanup after moving from Page to Emulation. (Closed)

Created:
5 years, 9 months ago by dgozman
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@emulation-domain-impl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Cleanup after moving from Page to Emulation. BUG=467059 Committed: https://crrev.com/59106c0bda26f66a76ff6dac1380294f97dfd138 Cr-Commit-Position: refs/heads/master@{#321752}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -208 lines) Patch
M content/browser/devtools/protocol/page_handler.h View 1 4 chunks +0 lines, -31 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 1 11 chunks +0 lines, -177 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dgozman
Take a look please.
5 years, 9 months ago (2015-03-18 16:46:17 UTC) #2
pfeldman
lgtm
5 years, 9 months ago (2015-03-19 11:04:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019533002/1
5 years, 9 months ago (2015-03-21 08:15:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/7503) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-21 08:18:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019533002/20001
5 years, 9 months ago (2015-03-23 08:56:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 09:52:25 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 09:53:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59106c0bda26f66a76ff6dac1380294f97dfd138
Cr-Commit-Position: refs/heads/master@{#321752}

Powered by Google App Engine
This is Rietveld 408576698