Disable autofill credit card save button if all fields are empty

Disable autofill credit card save button if all fields are empty

BUG=468219
Committed: https://crrev.com/4465771224b0d6161aebb8cc1bb7fa9dae72f28d
Cr-Commit-Position: refs/heads/master@{#321201}

R=newt@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/ff0883c6c5078c0c145e0b91f33c703c0abb2bc9

[Theresa, 2015-03-18 15:18:35]

twellington@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2015-03-18 18:19:16]

https://codereview.chromium.org/1019523002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/1019523002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:254:
private void setSaveButtonEnabled(boolean enabled) {
how about calling this updateSaveButtonEnabled() and putting all the logic for
whether the save button should be enabled or disabled inside this method?

https://codereview.chromium.org/1019523002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:255:
if (getView() != null) {
It doesn't appear possible for getView() to be null. Why add this?

[Theresa, 2015-03-18 18:51:53]

ptal

https://codereview.chromium.org/1019523002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/1019523002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:254:
private void setSaveButtonEnabled(boolean enabled) {
On 2015/03/18 18:19:16, newt wrote:
> how about calling this updateSaveButtonEnabled() and putting all the logic for
> whether the save button should be enabled or disabled inside this method?

Done.

https://codereview.chromium.org/1019523002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:255:
if (getView() != null) {
On 2015/03/18 18:19:16, newt wrote:
> It doesn't appear possible for getView() to be null. Why add this?

It was a copy-paste from AutofillProfileEditor. You are correct though, the view
will never be null when this method is called.

[newt (away), 2015-03-18 20:17:55]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-03-18 20:17:56]

lgtm

[commit-bot: I haz the power, 2015-03-18 20:18:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1019523002/20001

[commit-bot: I haz the power, 2015-03-18 20:56:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-18 20:57:27]

Patchset 2 (id:??) landed as
https://crrev.com/4465771224b0d6161aebb8cc1bb7fa9dae72f28d
Cr-Commit-Position: refs/heads/master@{#321201}

[newt (away), 2015-03-18 21:11:52]

Committed patchset #2 (id:20001) manually as
ff0883c6c5078c0c145e0b91f33c703c0abb2bc9.