Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1019463003: MIPS: Tweak constants to be in favor of table switch. (Closed)

Created:
5 years, 9 months ago by dusmil.imgtec
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Tweak constants to be in favor of table switch. In prevous set-up table switch is rarely generated. TEST=cctest/test-serialize/SerializeInternalReference BUG= Committed: https://crrev.com/b37c0890d44b36fa1c6580c3a9293e733778a3cf Cr-Commit-Position: refs/heads/master@{#27307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dusmil.imgtec
PTAL, We really need to improve jump tables to cost less. I suggest to switch ...
5 years, 9 months ago (2015-03-19 11:06:41 UTC) #2
balazs.kilvady
lgtm.
5 years, 9 months ago (2015-03-19 11:46:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019463003/1
5 years, 9 months ago (2015-03-19 12:53:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 13:57:03 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 13:57:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b37c0890d44b36fa1c6580c3a9293e733778a3cf
Cr-Commit-Position: refs/heads/master@{#27307}

Powered by Google App Engine
This is Rietveld 408576698