Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: Source/bindings/templates/methods.cpp

Issue 1019453002: IDL: Add [Custom=CallEpilogue] to eliminate CG special cases (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix after rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/interface.h ('k') | Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index 45573b80467b24b63aa5a7a0eba48d8d993cfb28..4110a88a37e1ef839ca78d07601d160185c94c70 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -270,16 +270,8 @@ else
{{v8_set_return_value}};
{% endif %}
{%- endif %}{# None for void #}
-{# Post-set #}
-{% if interface_name in ('EventTarget', 'MediaQueryList')
- and method.name in ('addEventListener', 'removeEventListener', 'addListener', 'removeListener') %}
-{% set hidden_dependency_action = 'addHiddenValueToArray'
- if method.name in ('addEventListener', 'addListener') else 'removeHiddenValueFromArray' %}
-{% set argument_index = '1' if interface_name == 'EventTarget' else '0' %}
-{# Length check needed to skip action on legacy calls without enough arguments.
- http://crbug.com/353484 #}
-if (info.Length() >= {{argument_index}} + 1 && listener && !impl->toNode())
- {{hidden_dependency_action}}(info.GetIsolate(), info.Holder(), info[{{argument_index}}], {{v8_class}}::eventListenerCacheIndex);
+{% if method.is_custom_call_epilogue %}
+{{v8_class}}::{{method.name}}MethodEpilogueCustom(info, impl);
{% endif %}
{% endmacro %}
« no previous file with comments | « Source/bindings/templates/interface.h ('k') | Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698