Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 1019453002: IDL: Add [Custom=CallEpilogue] to eliminate CG special cases (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix after rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/custom.gypi ('k') | Source/bindings/templates/interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index fb014a0ee6a69fb37aed34ad9857dfd9e55ef132..197cdfbfff6ad4b7b526b42e37934270cced54fe 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -114,6 +114,7 @@ def method_context(interface, method, is_visible=True):
not is_do_not_check_security)
is_raises_exception = 'RaisesException' in extended_attributes
+ is_custom_call_epilogue = has_extended_attribute_value(method, 'Custom', 'CallEpilogue')
return {
'activity_logging_world_list': v8_utilities.activity_logging_world_list(method), # [ActivityLogging]
@@ -151,7 +152,8 @@ def method_context(interface, method, is_visible=True):
'is_check_security_for_frame': is_check_security_for_frame,
'is_check_security_for_node': is_check_security_for_node,
'is_check_security_for_window': is_check_security_for_window,
- 'is_custom': 'Custom' in extended_attributes,
+ 'is_custom': 'Custom' in extended_attributes and not is_custom_call_epilogue,
+ 'is_custom_call_epilogue': is_custom_call_epilogue,
'is_custom_element_callbacks': is_custom_element_callbacks,
'is_do_not_check_security': is_do_not_check_security,
'is_do_not_check_signature': 'DoNotCheckSignature' in extended_attributes,
« no previous file with comments | « Source/bindings/core/v8/custom/custom.gypi ('k') | Source/bindings/templates/interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698