Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1019413002: Use TO_OBJECT_INLINE a bit more (Closed)

Created:
5 years, 9 months ago by arv (Not doing code reviews)
Modified:
5 years, 9 months ago
Reviewers:
adamk, rossberg, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use TO_OBJECT_INLINE a bit more We were using ToObject in a lot of places where the common case is that we already have an object. By changing to TO_OBJECT_INLINE we don't have to go through 5 different if statements before falling through. We were also calling ToObject too many times in DefineObjectProperty where we already know that obj is an object. BUG=None LOG=N Committed: https://crrev.com/2184431f4cc660e39610f4d17927e409c276e104 Cr-Commit-Position: refs/heads/master@{#27355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/v8natives.js View 13 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
arv (Not doing code reviews)
PTAL
5 years, 9 months ago (2015-03-19 22:24:50 UTC) #2
adamk
lgtm, nice cleanup
5 years, 9 months ago (2015-03-20 08:21:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019413002/1
5 years, 9 months ago (2015-03-20 16:59:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019413002/1
5 years, 9 months ago (2015-03-23 08:07:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 08:41:52 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 08:42:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2184431f4cc660e39610f4d17927e409c276e104
Cr-Commit-Position: refs/heads/master@{#27355}

Powered by Google App Engine
This is Rietveld 408576698