chrome/browser/ui/webui/options/core_options_handler.cc - Issue 1019403002: Fetch and actually set prefs (using chrome.send for now).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/core_options_handler.cc

Issue 1019403002: Fetch and actually set prefs (using chrome.send for now). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert unintended change. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/core_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/core_options_handler.cc b/chrome/browser/ui/webui/options/core_options_handler.cc

index 3ffe03457755544d452756992f37281e0a7e48b8..8cb3acd43e9fe4309ed21e447916d64ec0c41832 100644

--- a/chrome/browser/ui/webui/options/core_options_handler.cc

+++ b/chrome/browser/ui/webui/options/core_options_handler.cc

@@ -368,7 +368,7 @@ base::Value* CoreOptionsHandler::CreateValueForPref(

const PrefService::Preference* pref =

pref_service->FindPreference(pref_name.c_str());

if (!pref) {

- NOTREACHED();

+ // NOTREACHED();

James Hawkins 2015/03/19 22:23:34 Ship it

Jeremy Klein 2015/03/19 22:39:44 Haha, removed. Just trying things out :-)

return base::Value::CreateNullValue();

}

const PrefService::Preference* controlling_pref =

« chrome/browser/ui/webui/md_settings_ui.h ('K') | « chrome/browser/ui/webui/md_settings_ui.cc ('k') | no next file » | no next file with comments »