chrome/browser/resources/settings/prefs/prefs.html - Issue 1019403002: Fetch and actually set prefs (using chrome.send for now).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/prefs/prefs.html

Issue 1019403002: Fetch and actually set prefs (using chrome.send for now). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix cros-only Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/downloads_page/downloads_page.html ('k') | chrome/browser/resources/settings/prefs/prefs.js » ('j') | chrome/browser/ui/webui/md_settings_ui.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <script src="chrome://resources/js/assert.js"></script>
	Kyle Horimoto 2015/03/19 22:42:11 Using a <script> instead of a <link rel="import"> Using a <script> instead of a <link rel="import"> will NOT dedupe the request, right? So, if we include the same script multiple times, bad stuff will happen? We should probably figure out a centralized way to do this instead of doing it on an individual element. Jeremy Klein 2015/03/19 23:04:21 I'm glad you brought this up because I actually me Show quoted text On 2015/03/19 22:42:11, Kyle Horimoto wrote: > Using a <script> instead of a <link rel="import"> will NOT dedupe the request, > right? So, if we include the same script multiple times, bad stuff will happen? > We should probably figure out a centralized way to do this instead of doing it > on an individual element. I'm glad you brought this up because I actually meant to ask about it! In these cases, it isn't actually a big deal to duplicate the scripts, but I do agree that it would be cool to take advantage of the deduping that imports give us. This will basically mean wrapping assert.js and cr.js in assert.html and cr.html with only a script tag. I'm actually cool with this and will go ahead and do it as long as there aren't any strong objections. There is precedent for this in files like this: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/polyme... I think it's a nice pattern to follow for dependency management.
	3 <script src="chrome://resources/js/cr.js"></script>

2	4

3 <polymer-element name="cr-settings-prefs">	5 <polymer-element name="cr-settings-prefs">

4 <script src="prefs.js"></script>	6 <script src="prefs.js"></script>

5 </polymer-element>	7 </polymer-element>

OLD	NEW