Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1019373002: Add color/ directory from foxit to test case repository (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add color/ directory to test case repository. Files are renamed from the foxit drop to match our conventions, removing spaces and odd punctuation, making lower case, and using _ as a separator. Expected output files are generated from build at 74b81d9, will ask for verification after commit. R=thestig@chromium.org Committed: 4a944b7fad24b2b9de12e50d98e9c9d98104e15f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1261 lines, -0 lines) Patch
A fx/color/2_color_calrgb.pdf View 1 chunk +210 lines, -0 lines 0 comments Download
A fx/color/2_color_calrgb_expected.pdf.0.png View Binary file 0 comments Download
A fx/color/2_color_indexed.pdf View 1 chunk +236 lines, -0 lines 0 comments Download
A fx/color/2_color_indexed_expected.pdf.0.png View Binary file 0 comments Download
A fx/color/2_color_lab.pdf View 1 chunk +150 lines, -0 lines 0 comments Download
A fx/color/2_color_lab_expected.pdf.0.png View Binary file 0 comments Download
A fx/color/color.pdf View 1 chunk +245 lines, -0 lines 0 comments Download
A fx/color/color_calgray.pdf View 1 chunk +73 lines, -0 lines 0 comments Download
A fx/color/color_calgray_expected.pdf.0.png View Binary file 0 comments Download
A fx/color/color_calrgb.pdf View 1 chunk +75 lines, -0 lines 0 comments Download
A fx/color/color_calrgb_expected.pdf.0.png View Binary file 0 comments Download
A fx/color/color_expected.pdf.0.png View Binary file 0 comments Download
A fx/color/color_icc_based.pdf View 1 chunk +114 lines, -0 lines 0 comments Download
A fx/color/color_icc_based_expected.pdf.0.png View Binary file 0 comments Download
A fx/color/color_lab.pdf View 1 chunk +73 lines, -0 lines 0 comments Download
A fx/color/color_lab_expected.pdf.0.png View Binary file 0 comments Download
A fx/color/color_separation.pdf View 1 chunk +85 lines, -0 lines 0 comments Download
A fx/color/color_separation_expected.pdf.0.png View Binary file 0 comments Download
A fx/color/colorspace.pdf View Binary file 0 comments Download
A fx/color/colorspace_expected.pdf.0.png View Binary file 0 comments Download
A fx/color/colorspace_test.pdf View Binary file 0 comments Download
A fx/color/colorspace_test1.pdf View Binary file 0 comments Download
A fx/color/colorspace_test1_expected.pdf.0.png View Binary file 0 comments Download
A fx/color/colorspace_test_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for a second set of eyes, just because.
5 years, 9 months ago (2015-03-19 19:42:10 UTC) #2
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-19 20:45:16 UTC) #3
Tom Sepez
5 years, 9 months ago (2015-03-19 20:46:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4a944b7fad24b2b9de12e50d98e9c9d98104e15f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698