Source/core/html/HTMLTextFormControlElement.cpp - Issue 1019353007: Merge 190609 "Ignore setSelectionRange when node is un-parented."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 1019353007: Merge 190609 "Ignore setSelectionRange when node is un-parented." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/2311/

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTextFormControlElement.cpp

===================================================================

--- Source/core/html/HTMLTextFormControlElement.cpp (revision 192381)

+++ Source/core/html/HTMLTextFormControlElement.cpp (working copy)

@@ -348,7 +348,7 @@

void HTMLTextFormControlElement::setSelectionRange(int start, int end, TextFieldSelectionDirection direction, NeedToDispatchSelectEvent eventBehaviour, SelectionOption selectionOption)

{

- if (hasOpenShadowRoot() || !isTextFormControl())

+ if (hasOpenShadowRoot() || !isTextFormControl() || !inDocument())

return;

const int editorValueLength = static_cast<int>(innerEditorValue().length());

« no previous file with comments | « LayoutTests/editing/input/orphan-set-selection-range-expected.txt ('k') | no next file » | no next file with comments »