Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1019353006: Version 4.2.77.12 (cherry-pick) (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
CC:
v8-dev, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.2
Target Ref:
refs/pending/branch-heads/4.2
Project:
v8
Visibility:
Public.

Description

Version 4.2.77.12 (cherry-pick) Merged a3773e4d29e97b912ef284ee62bd8011ef6884af X87: Implement subclassing Arrays. R=dslomov@chromium.org BUG= Committed: https://chromium.googlesource.com/v8/v8/+/b0a290c40d88d13f32ea0e2370c62d2316ca8638

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 3 chunks +23 lines, -5 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
chunyang.dai
5 years, 9 months ago (2015-03-23 17:38:37 UTC) #1
chunyang.dai
PTAL.
5 years, 9 months ago (2015-03-23 17:40:53 UTC) #2
Dmitry Lomov (no reviews)
https://codereview.chromium.org/1019353006/diff/1/src/x87/code-stubs-x87.cc File src/x87/code-stubs-x87.cc (left): https://codereview.chromium.org/1019353006/diff/1/src/x87/code-stubs-x87.cc#oldcode4325 src/x87/code-stubs-x87.cc:4325: __ cmp(edx, edi); Why this comparison and branch got ...
5 years, 9 months ago (2015-03-23 17:42:49 UTC) #3
chunyang.dai
On 2015/03/23 17:42:49, Dmitry Lomov (chromium) wrote: > https://codereview.chromium.org/1019353006/diff/1/src/x87/code-stubs-x87.cc > File src/x87/code-stubs-x87.cc (left): > > ...
5 years, 9 months ago (2015-03-23 17:53:09 UTC) #4
Dmitry Lomov (no reviews)
On 2015/03/23 17:53:09, chunyang.dai wrote: > On 2015/03/23 17:42:49, Dmitry Lomov (chromium) wrote: > > ...
5 years, 9 months ago (2015-03-23 20:35:50 UTC) #5
chunyang.dai
5 years, 9 months ago (2015-03-23 23:48:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b0a290c40d88d13f32ea0e2370c62d2316ca8638.

Powered by Google App Engine
This is Rietveld 408576698