Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1019353002: cc: Add priority rects to tracing. (Closed)

Created:
5 years, 9 months ago by vmpstr
Modified:
5 years, 9 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add priority rects to tracing. This patch adds all of the priority rects we use in tilings to tracing. R=enne BUG=468813 Committed: https://crrev.com/1f29e546cfaab38762704455935c116c6bd18252 Cr-Commit-Position: refs/heads/master@{#321434}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M cc/resources/picture_layer_tiling.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
vmpstr
Please take a look.
5 years, 9 months ago (2015-03-19 19:06:35 UTC) #1
enne (OOO)
https://codereview.chromium.org/1019353002/diff/1/cc/resources/picture_layer_tiling.cc File cc/resources/picture_layer_tiling.cc (right): https://codereview.chromium.org/1019353002/diff/1/cc/resources/picture_layer_tiling.cc#newcode887 cc/resources/picture_layer_tiling.cc:887: MathUtil::AddToTracedValue("current_visible_rect", current_visible_rect_, Do you need the word current in ...
5 years, 9 months ago (2015-03-19 19:15:22 UTC) #2
vmpstr
PTAL https://codereview.chromium.org/1019353002/diff/1/cc/resources/picture_layer_tiling.cc File cc/resources/picture_layer_tiling.cc (right): https://codereview.chromium.org/1019353002/diff/1/cc/resources/picture_layer_tiling.cc#newcode887 cc/resources/picture_layer_tiling.cc:887: MathUtil::AddToTracedValue("current_visible_rect", current_visible_rect_, On 2015/03/19 19:15:21, enne wrote: > ...
5 years, 9 months ago (2015-03-19 19:38:19 UTC) #3
enne (OOO)
lgtm
5 years, 9 months ago (2015-03-19 20:10:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019353002/20001
5 years, 9 months ago (2015-03-19 20:11:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 21:23:48 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 21:24:18 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f29e546cfaab38762704455935c116c6bd18252
Cr-Commit-Position: refs/heads/master@{#321434}

Powered by Google App Engine
This is Rietveld 408576698