Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 101933004: Eager Gesture Recognizer (WIP) (Closed)

Created:
7 years ago by tdresser
Modified:
6 years, 11 months ago
Reviewers:
CC:
chromium-reviews, ben+aura_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, sadrul, James Su, miu+watch_chromium.org, jdduke (slow)
Visibility:
Public.

Description

Eager Gesture Recognizer (WIP) Still very much a work in progress. The eager GR hasn't been plumbed into either clank or aura yet. Further work is currently blocked on implementing the tap end gesture (crbug.com/295665). EagerGestureRecognitionAuraTest is an integration test which shows approximately how eager gesture recognition will be wired up in the aura case. BUG=295075 TEST=GestureEventQueueTest.*:TouchPointStateTest.*: EagerGestureRecognitionAuraTest.*

Patch Set 1 #

Patch Set 2 : Started plumbing Aura #

Patch Set 3 : Partially working on Aura. #

Patch Set 4 : Starting work on Android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1773 lines, -200 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 2 3 4 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 chunks +14 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java View 1 2 3 2 chunks +37 lines, -36 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
A ui/aura/gestures/eager_gesture_recognition_aura_unittest.cc View 1 3 1 chunk +282 lines, -0 lines 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 2 3 5 chunks +9 lines, -7 lines 0 comments Download
M ui/aura/root_window.h View 1 2 3 8 chunks +14 lines, -4 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 3 10 chunks +69 lines, -58 lines 0 comments Download
M ui/events/events.gyp View 1 2 3 4 chunks +13 lines, -2 lines 0 comments Download
A ui/events/gestures/gesture_event_queue.h View 1 3 1 chunk +104 lines, -0 lines 0 comments Download
A ui/events/gestures/gesture_event_queue.cc View 1 3 1 chunk +238 lines, -0 lines 0 comments Download
A ui/events/gestures/gesture_event_queue_unittest.cc View 1 1 chunk +454 lines, -0 lines 0 comments Download
M ui/events/gestures/gesture_recognizer.h View 1 3 2 chunks +5 lines, -3 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.h View 1 3 3 chunks +7 lines, -9 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.cc View 1 3 3 chunks +9 lines, -17 lines 0 comments Download
M ui/events/gestures/gesture_sequence.h View 1 6 chunks +15 lines, -21 lines 0 comments Download
M ui/events/gestures/gesture_sequence.cc View 1 2 3 8 chunks +53 lines, -33 lines 0 comments Download
M ui/events/gestures/gesture_types.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
A ui/events/gestures/test/eager_gesture_recognition_test_base.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ui/events/gestures/test/eager_gesture_recognition_test_base.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A ui/events/gestures/touch_point_state.h View 1 1 chunk +74 lines, -0 lines 0 comments Download
A ui/events/gestures/touch_point_state.cc View 1 3 1 chunk +156 lines, -0 lines 0 comments Download
A ui/events/gestures/touch_point_state_unittest.cc View 1 3 1 chunk +119 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tdresser
Feel free to take an initial look - lot's of this will change, and it ...
7 years ago (2013-12-03 16:20:17 UTC) #1
tdresser
6 years, 11 months ago (2014-01-21 18:53:19 UTC) #2
Message was sent while issue was closed. 
Closing for now, as jdduke has a simpler patch in progress which takes advantage
of some recent changes in how we want to handle touch dispositions.

jdduke's patch here: https://codereview.chromium.org/120513005/

Powered by Google App Engine
This is Rietveld 408576698