Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 101933003: Preserving inline style of the replaced block element for FormatBlock('execCommand'). (Closed)

Created:
7 years ago by arpitab_
Modified:
7 years ago
Reviewers:
yosin, ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Preserving inline style of the replaced block element for FormatBlock('execCommand'). With 'FormatBlock', the newly inserted block-style element would not possess any of the inline style properties of the original block element containing the current selection. Thus, as the associated bug describes, we need to either add a style attribute to the newly added block-style element or, add another style span with the inline style of the replaced block element. This patch takes the approach of adding the inline style to the new block-style element itself. BUG=324181 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163137

Patch Set 1 #

Patch Set 2 : Rebaselining #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -0 lines) Patch
A LayoutTests/editing/execCommand/format-block-with-block.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/editing/execCommand/format-block-with-block-expected.txt View 1 chunk +56 lines, -0 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.cpp View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arpitab_
7 years ago (2013-12-03 14:19:51 UTC) #1
ojan
lgtm
7 years ago (2013-12-04 00:01:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/101933003/20001
7 years ago (2013-12-04 00:01:35 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-04 02:00:08 UTC) #4
Message was sent while issue was closed.
Change committed as 163137

Powered by Google App Engine
This is Rietveld 408576698