Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1019323002: Make the terminal demo able (to try) to connect to anything. (Closed)

Created:
5 years, 9 months ago by viettrungluu
Modified:
5 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, abarth-chromium
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make the terminal demo able (to try) to connect to anything. (Using the query string from the URL.) R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/319a697359c29ba55df8c7feba4b4dd94a7dd3b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M sky/examples/terminal/index.sky View 1 chunk +19 lines, -1 line 0 comments Download
M sky/examples/terminal/terminal.sky View 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 9 months ago (2015-03-19 17:54:02 UTC) #1
Elliot Glaysher
lgtm
5 years, 9 months ago (2015-03-19 18:05:54 UTC) #2
viettrungluu
5 years, 9 months ago (2015-03-19 18:15:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
319a697359c29ba55df8c7feba4b4dd94a7dd3b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698