Use c++11 range loops in accessibility

Source/modules/accessibility/AXObject.cpp

 /*
  * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 517 matching lines @@
 {
     return isProgressIndicator()
         || isMeter()
         || isSlider()
         || isScrollbar()
         || isSpinButton();
 }
 
 void AXObject::ariaTreeRows(AccessibilityChildrenVector& result)
 {
-    const AccessibilityChildrenVector& axChildren = children();
-    unsigned count = axChildren.size();
-    for (unsigned k = 0; k < count; ++k) {
-        AXObject* obj = axChildren[k].get();
-
+    for (const auto& child : children()) {
         // Add tree items as the rows.
-        if (obj->roleValue() == TreeItemRole)
-            result.append(obj);
+        if (child->roleValue() == TreeItemRole)
+            result.append(child);
 
         // Now see if this item also has rows hiding inside of it.
-        obj->ariaTreeRows(result);
+        child->ariaTreeRows(result);
     }
 }
 
 bool AXObject::isLiveRegion() const
 {
     const AtomicString& liveRegion = liveRegionStatus();
     return equalIgnoringCase(liveRegion, "polite") || equalIgnoringCase(liveRegion, "assertive");
 }
 
 const AXObject* AXObject::liveRegionRoot() const
@@ skipping 21 matching lines @@
 }
 
 bool AXObject::containerLiveRegionBusy() const
 {
     updateCachedAttributeValuesIfNeeded();
     return m_cachedLiveRegionRoot ? m_cachedLiveRegionRoot->liveRegionBusy() : false;
 }
 
 void AXObject::markCachedElementRectDirty() const
 {
-    for (unsigned i = 0; i < m_children.size(); ++i)
-        m_children[i].get()->markCachedElementRectDirty();
+    for (const auto& child : m_children)
+        child->markCachedElementRectDirty();
 }
 
 IntPoint AXObject::clickPoint()
 {
     LayoutRect rect = elementRect();
     return roundedIntPoint(LayoutPoint(rect.x() + rect.width() / 2, rect.y() + rect.height() / 2));
 }
 
 IntRect AXObject::boundingBoxForQuads(LayoutObject* obj, const Vector<FloatQuad>& quads)
 {
@@ skipping 21 matching lines @@
 {
     // Send the hit test back into the sub-frame if necessary.
     if (isAttachment()) {
         Widget* widget = widgetForAttachmentView();
         // Normalize the point for the widget's bounds.
         if (widget && widget->isFrameView())
             return axObjectCache()->getOrCreate(widget)->accessibilityHitTest(IntPoint(point - widget->frameRect().location()));
     }
 
     // Check if there are any mock elements that need to be handled.
-    size_t count = m_children.size();
-    for (size_t k = 0; k < count; k++) {
-        if (m_children[k]->isMockObject() && m_children[k]->elementRect().contains(point))
-            return m_children[k]->elementAccessibilityHitTest(point);
+    for (const auto& child : m_children) {
+        if (child->isMockObject() && child->elementRect().contains(point))
+            return child->elementAccessibilityHitTest(point);
     }
 
     return const_cast<AXObject*>(this);
 }
 
 const AXObject::AccessibilityChildrenVector& AXObject::children()
 {
     updateChildrenIfNecessary();
 
     return m_children;
@@ skipping 32 matching lines @@
 
 void AXObject::updateChildrenIfNecessary()
 {
     if (!hasChildren())
         addChildren();
 }
 
 void AXObject::clearChildren()
 {
     // Detach all weak pointers from objects to their parents.
-    size_t length = m_children.size();
-    for (size_t i = 0; i < length; i++)
-        m_children[i]->detachFromParent();
+    for (const auto& child : m_children)
+        child->detachFromParent();
 
     m_children.clear();
     m_haveChildren = false;
 }
 
 AXObject* AXObject::focusedUIElement() const
 {
     Document* doc = document();
     if (!doc)
         return 0;
@@ skipping 337 matching lines @@
 
 AccessibilityRole AXObject::ariaRoleToWebCoreRole(const String& value)
 {
     ASSERT(!value.isEmpty());
 
     static const ARIARoleMap* roleMap = createARIARoleMap();
 
     Vector<String> roleVector;
     value.split(' ', roleVector);
     AccessibilityRole role = UnknownRole;
-    unsigned size = roleVector.size();
-    for (unsigned i = 0; i < size; ++i) {
-        String roleName = roleVector[i];
-        role = roleMap->get(roleName);
+    for (const auto& child : roleVector) {
+        role = roleMap->get(child);
         if (role)
             return role;
     }
 
     return role;
 }
 
 bool AXObject::isInsideFocusableElementOrARIAWidget(const Node& node)
 {
     const Node* curNode = &node;
@@ skipping 23 matching lines @@
     }
     return false;
 }
 
 bool AXObject::includesARIAWidgetRole(const String& role)
 {
     static const HashSet<String, CaseFoldingHash>* roleSet = createARIARoleWidgetSet();
 
     Vector<String> roleVector;
     role.split(' ', roleVector);
-    unsigned size = roleVector.size();
-    for (unsigned i = 0; i < size; ++i) {
-        String roleName = roleVector[i];
-        if (roleSet->contains(roleName))
+    for (const auto& child : roleVector) {
+        if (roleSet->contains(child))
             return true;
     }
     return false;
 }
 
 AccessibilityRole AXObject::buttonRoleType() const
 {
     // If aria-pressed is present, then it should be exposed as a toggle button.
     // http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
     if (ariaPressedIsPresent())
         return ToggleButtonRole;
     if (ariaHasPopup())
         return PopUpButtonRole;
     // We don't contemplate RadioButtonRole, as it depends on the input
     // type.
 
     return ButtonRole;
 }
 
 const AtomicString& AXObject::roleName(AccessibilityRole role)
 {
     static const Vector<AtomicString>* roleNameVector = createRoleNameVector();
 
     return roleNameVector->at(role);
 }
 
 } // namespace blink