Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1019303004: [Extensions] Fix reloading crashed extensions from chrome://extensions (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Fix reloading crashed extensions from chrome://extensions BUG=463780 Committed: https://crrev.com/51a850d2cef7ed5f26518b09443da9f4a778a50c Cr-Commit-Position: refs/heads/master@{#321405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/extensions/extension_list.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Devlin
5 years, 9 months ago (2015-03-19 16:24:37 UTC) #2
Dan Beam
i tried to think of a useful regression test for this and failed. lgtm but ...
5 years, 9 months ago (2015-03-19 17:30:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019303004/1
5 years, 9 months ago (2015-03-19 17:33:45 UTC) #5
Devlin
On 2015/03/19 17:30:06, Dan Beam wrote: > i tried to think of a useful regression ...
5 years, 9 months ago (2015-03-19 17:41:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 19:20:21 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 19:21:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51a850d2cef7ed5f26518b09443da9f4a778a50c
Cr-Commit-Position: refs/heads/master@{#321405}

Powered by Google App Engine
This is Rietveld 408576698