Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1019303002: Revert "Prevent chrome://net-internals/#export from flickering" (Closed)

Created:
5 years, 9 months ago by mmenke
Modified:
5 years, 9 months ago
CC:
chromium-reviews, eroman, arv+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Prevent chrome://net-internals/#export from flickering" This reverts commit b55be9ede35c10a2623c3c348768db92069d7f10. This broke layout of the filter box in the events tab. Reverted CL description: The problem: 1. Initially all the tabs are visible 2. A layout happens 3. index.js is run and it sets all the tabs to display: none This results in the flickering. By initially giving div main-tab-contents the style display: none and removing that in initTabs_() we can prevent the flickering. BUG=466068 Committed: https://crrev.com/b55be9ede35c10a2623c3c348768db92069d7f10 Cr-Commit-Position: refs/heads/master@{#320264} TBR=eroman@chromium.org, alexclarke1@chromium.org Committed: https://crrev.com/f5d6a7049532a82187d4a6ccc330f26182e046ae Cr-Commit-Position: refs/heads/master@{#321364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/resources/net_internals/index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/main.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mmenke
5 years, 9 months ago (2015-03-19 14:23:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019303002/1
5 years, 9 months ago (2015-03-19 14:24:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 16:03:01 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 16:03:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5d6a7049532a82187d4a6ccc330f26182e046ae
Cr-Commit-Position: refs/heads/master@{#321364}

Powered by Google App Engine
This is Rietveld 408576698