Fix broken JSFunction::is_compiled predicate.

src/objects-inl.h

Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 94a3cb3c947a63512d0515cee178bc5e47bcbee5..c588f8345c90fb8098aee8239ff8a59df0c0596d 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -5843,7 +5843,10 @@ void SharedFunctionInfo::set_scope_info(ScopeInfo* value,
 
 
 bool SharedFunctionInfo::is_compiled() {
-  return code() != GetIsolate()->builtins()->builtin(Builtins::kCompileLazy);
+  Builtins* builtins = GetIsolate()->builtins();
+  DCHECK(code() != builtins->builtin(Builtins::kCompileOptimizedConcurrent));
+  DCHECK(code() != builtins->builtin(Builtins::kCompileOptimized));
+  return code() != builtins->builtin(Builtins::kCompileLazy);
 }
 
 
@@ -6126,7 +6129,10 @@ bool JSFunction::should_have_prototype() {
 
 
 bool JSFunction::is_compiled() {
-  return code() != GetIsolate()->builtins()->builtin(Builtins::kCompileLazy);
+  Builtins* builtins = GetIsolate()->builtins();
+  return code() != builtins->builtin(Builtins::kCompileLazy) &&
+         code() != builtins->builtin(Builtins::kCompileOptimized) &&
+         code() != builtins->builtin(Builtins::kCompileOptimizedConcurrent);

[Yang, 2015/03/26 14:23:12]

Can it be anything else than these three anyways? If not, we could just check
code kind, and DCHECK that it's one of these three.

[Michael Starzinger, 2015/03/26 14:57:00]

As discussed offline: We see different Code::Kinds coming in here. There at
least is FUNCTION, OPTIMIZED_FUNCTION and BUILTIN coming in. So the number of
comparisons wouldn't really change. Also BUILTIN might for example be kIllegal
or kEmptyFunction (considered compiled) or kCompileLazy (considered
non-compiled). So I think the Code::Kind won't be helping us much here.

 }