Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: src/objects.cc

Issue 1019293003: Fix broken JSFunction::is_compiled predicate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove stray assert. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/factory.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <iomanip> 5 #include <iomanip>
6 #include <sstream> 6 #include <sstream>
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/accessors.h" 10 #include "src/accessors.h"
(...skipping 9672 matching lines...) Expand 10 before | Expand all | Expand 10 after
9683 } 9683 }
9684 if (isolate->concurrent_osr_enabled() && 9684 if (isolate->concurrent_osr_enabled() &&
9685 isolate->optimizing_compiler_thread()->IsQueuedForOSR(this)) { 9685 isolate->optimizing_compiler_thread()->IsQueuedForOSR(this)) {
9686 // Do not attempt regular recompilation if we already queued this for OSR. 9686 // Do not attempt regular recompilation if we already queued this for OSR.
9687 // TODO(yangguo): This is necessary so that we don't install optimized 9687 // TODO(yangguo): This is necessary so that we don't install optimized
9688 // code on a function that is already optimized, since OSR and regular 9688 // code on a function that is already optimized, since OSR and regular
9689 // recompilation race. This goes away as soon as OSR becomes one-shot. 9689 // recompilation race. This goes away as soon as OSR becomes one-shot.
9690 return; 9690 return;
9691 } 9691 }
9692 DCHECK(!IsInOptimizationQueue()); 9692 DCHECK(!IsInOptimizationQueue());
9693 DCHECK(is_compiled() || isolate->debug()->has_break_points());
9694 DCHECK(!IsOptimized()); 9693 DCHECK(!IsOptimized());
9695 DCHECK(shared()->allows_lazy_compilation() || code()->optimizable()); 9694 DCHECK(shared()->allows_lazy_compilation() || code()->optimizable());
9696 DCHECK(isolate->concurrent_recompilation_enabled()); 9695 DCHECK(isolate->concurrent_recompilation_enabled());
9697 if (FLAG_trace_concurrent_recompilation) { 9696 if (FLAG_trace_concurrent_recompilation) {
9698 PrintF(" ** Marking "); 9697 PrintF(" ** Marking ");
9699 ShortPrint(); 9698 ShortPrint();
9700 PrintF(" for concurrent recompilation.\n"); 9699 PrintF(" for concurrent recompilation.\n");
9701 } 9700 }
9702 set_code_no_write_barrier( 9701 set_code_no_write_barrier(
9703 GetIsolate()->builtins()->builtin(Builtins::kCompileOptimizedConcurrent)); 9702 GetIsolate()->builtins()->builtin(Builtins::kCompileOptimizedConcurrent));
(...skipping 7465 matching lines...) Expand 10 before | Expand all | Expand 10 after
17169 CompilationInfo* info) { 17168 CompilationInfo* info) {
17170 Handle<DependentCode> codes = DependentCode::InsertCompilationInfo( 17169 Handle<DependentCode> codes = DependentCode::InsertCompilationInfo(
17171 handle(cell->dependent_code(), info->isolate()), 17170 handle(cell->dependent_code(), info->isolate()),
17172 DependentCode::kPropertyCellChangedGroup, info->object_wrapper()); 17171 DependentCode::kPropertyCellChangedGroup, info->object_wrapper());
17173 if (*codes != cell->dependent_code()) cell->set_dependent_code(*codes); 17172 if (*codes != cell->dependent_code()) cell->set_dependent_code(*codes);
17174 info->dependencies(DependentCode::kPropertyCellChangedGroup)->Add( 17173 info->dependencies(DependentCode::kPropertyCellChangedGroup)->Add(
17175 cell, info->zone()); 17174 cell, info->zone());
17176 } 17175 }
17177 17176
17178 } } // namespace v8::internal 17177 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/factory.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698