Fix broken JSFunction::is_compiled predicate.

Fix broken JSFunction::is_compiled predicate.

The aforementioned predicate reported a JSFunction that was marked for
optimization as already compiled. This in turn also prevented us from
being aggressive about FLAG_always_opt treatment.

R=yangguo@chromium.org

Committed: https://crrev.com/3ad973a16fd7071f878135e864a2505668f6f21b
Cr-Commit-Position: refs/heads/master@{#27481}

[titzer, 2015-03-26 14:15:49]

titzer@chromium.org changed reviewers:
+ titzer@chromium.org

[titzer, 2015-03-26 14:15:50]

lgtm

[Yang, 2015-03-26 14:23:12]

lgtm

https://codereview.chromium.org/1019293003/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1019293003/diff/1/src/objects-inl.h#newcode6135
src/objects-inl.h:6135: code() !=
builtins->builtin(Builtins::kCompileOptimizedConcurrent);
Can it be anything else than these three anyways? If not, we could just check
code kind, and DCHECK that it's one of these three.

[Michael Starzinger, 2015-03-26 14:57:00]

https://codereview.chromium.org/1019293003/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1019293003/diff/1/src/objects-inl.h#newcode6135
src/objects-inl.h:6135: code() !=
builtins->builtin(Builtins::kCompileOptimizedConcurrent);
On 2015/03/26 14:23:12, Yang wrote:
> Can it be anything else than these three anyways? If not, we could just check
> code kind, and DCHECK that it's one of these three.

As discussed offline: We see different Code::Kinds coming in here. There at
least is FUNCTION, OPTIMIZED_FUNCTION and BUILTIN coming in. So the number of
comparisons wouldn't really change. Also BUILTIN might for example be kIllegal
or kEmptyFunction (considered compiled) or kCompileLazy (considered
non-compiled). So I think the Code::Kind won't be helping us much here.

[Michael Starzinger, 2015-03-26 15:03:08]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-03-26 15:03:08]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1019293003/#ps20001
(title: "Remove stray assert.")

[commit-bot: I haz the power, 2015-03-26 15:03:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1019293003/20001

[commit-bot: I haz the power, 2015-03-26 15:04:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-26 15:04:56]

Patchset 2 (id:??) landed as
https://crrev.com/3ad973a16fd7071f878135e864a2505668f6f21b
Cr-Commit-Position: refs/heads/master@{#27481}