Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1019293002: [turbofan] Use proper parameter representation for stub calls. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use proper parameter representation for stub calls. The CallInterfaceDescriptor already provides information about the expected representation of parameters, so we can use that instead of hardcoding tagged representation for all parameters. R=jarin@chromium.org Committed: https://crrev.com/fb966fd666e8958717828e6b2bc9411808211bc7 Cr-Commit-Position: refs/heads/master@{#27308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M src/compiler/linkage-impl.h View 3 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-19 13:05:39 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-19 13:06:43 UTC) #2
Jarin
lgtm
5 years, 9 months ago (2015-03-19 13:09:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019293002/1
5 years, 9 months ago (2015-03-19 13:09:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 13:58:09 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 13:58:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb966fd666e8958717828e6b2bc9411808211bc7
Cr-Commit-Position: refs/heads/master@{#27308}

Powered by Google App Engine
This is Rietveld 408576698