Cleanup the ConfigurationPolicyHandler interface.

Cleanup the ConfigurationPolicyHandler interface.

After https://codereview.chromium.org/197013007
ConfigurationPolicyHandler provided a default implementation of ApplyPolicySettings() that simply called NOTREACHED.
Also it wasn't clear anymore what of ConfigurationPolicyHandler is the public interface and what is default implementation.

Both issues are resolved with this change.

Committed: https://crrev.com/353879e53d35d8ea96bf29483eb7994fb44e7cf3
Cr-Commit-Position: refs/heads/master@{#322381}

[pneubeck (no reviews), 2015-03-25 15:49:50]

pneubeck@chromium.org changed reviewers:
+ mnissler@chromium.org

[pneubeck (no reviews), 2015-03-25 15:49:51]

ptal

[Mattias Nissler (ping if slow), 2015-03-26 11:13:59]

LGTM

I'd still prefer if we didn't have two functions, but just one, but that's not
the objective of this CL.

https://codereview.chromium.org/1019283005/diff/1/components/policy/core/brow...
File components/policy/core/browser/configuration_policy_handler.cc (right):

https://codereview.chromium.org/1019283005/diff/1/components/policy/core/brow...
components/policy/core/browser/configuration_policy_handler.cc:477: if
(!(*handler)->CheckPolicySettings(policies, &scoped_errors)) {
Wait, is the change of polarity in this conditional intentional?

[pneubeck (no reviews), 2015-03-26 14:53:34]

https://codereview.chromium.org/1019283005/diff/1/components/policy/core/brow...
File components/policy/core/browser/configuration_policy_handler.cc (right):

https://codereview.chromium.org/1019283005/diff/1/components/policy/core/brow...
components/policy/core/browser/configuration_policy_handler.cc:477: if
(!(*handler)->CheckPolicySettings(policies, &scoped_errors)) {
On 2015/03/26 11:13:59, Mattias Nissler wrote:
> Wait, is the change of polarity in this conditional intentional?

Thanks for catching!
that's also why the tests failed.

[pneubeck (no reviews), 2015-03-26 14:53:37]

The CQ bit was checked by pneubeck@chromium.org

[pneubeck (no reviews), 2015-03-26 14:53:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
mnissler@chromium.org
Link to the patchset: https://codereview.chromium.org/1019283005/#ps20001
(title: "Fix if condition.")

[commit-bot: I haz the power, 2015-03-26 14:54:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1019283005/20001

[commit-bot: I haz the power, 2015-03-26 14:57:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-26 14:58:08]

Patchset 2 (id:??) landed as
https://crrev.com/353879e53d35d8ea96bf29483eb7994fb44e7cf3
Cr-Commit-Position: refs/heads/master@{#322381}