Switch to direct use of OwnerSettingsServiceChromeOS::Set() in tests.

chrome/browser/chromeos/login/users/user_manager_unittest.cc

Index: chrome/browser/chromeos/login/users/user_manager_unittest.cc
diff --git a/chrome/browser/chromeos/login/users/user_manager_unittest.cc b/chrome/browser/chromeos/login/users/user_manager_unittest.cc
index 3765efa4651b545664701ac8c717fd3691647004..b2e6368ece6f74a8757f46e6ac2a702deecf8607 100644
--- a/chrome/browser/chromeos/login/users/user_manager_unittest.cc
+++ b/chrome/browser/chromeos/login/users/user_manager_unittest.cc
@@ -11,14 +11,11 @@
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
 #include "base/run_loop.h"
-#include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/login/users/chrome_user_manager_impl.h"
 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
 #include "chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h"
-#include "chrome/browser/chromeos/settings/cros_settings.h"
-#include "chrome/browser/chromeos/settings/device_settings_service.h"
-#include "chrome/browser/chromeos/settings/stub_cros_settings_provider.h"
+#include "chrome/browser/chromeos/settings/scoped_cros_settings_test_helper.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/test/base/scoped_testing_local_state.h"
 #include "chrome/test/base/testing_browser_process.h"
@@ -26,7 +23,6 @@
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/settings/cros_settings_names.h"
-#include "chromeos/settings/cros_settings_provider.h"
 #include "components/user_manager/user.h"
 #include "components/user_manager/user_manager.h"
 #include "content/public/common/content_switches.h"
@@ -50,7 +46,6 @@ class UnittestProfileManager : public ::ProfileManagerWithoutInit {
   }
 };
 
-
 class UserManagerTest : public testing::Test {
  protected:
   void SetUp() override {
@@ -59,15 +54,7 @@ class UserManagerTest : public testing::Test {
     command_line.AppendSwitch(
         chromeos::switches::kIgnoreUserProfileMappingForTests);
 
-    cros_settings_ = CrosSettings::Get();
-
-    // Replace the real DeviceSettingsProvider with a stub.
-    device_settings_provider_ =
-        cros_settings_->GetProvider(chromeos::kReportDeviceVersionInfo);
-    EXPECT_TRUE(device_settings_provider_);
-    EXPECT_TRUE(
-        cros_settings_->RemoveSettingsProvider(device_settings_provider_));
-    cros_settings_->AddSettingsProvider(&stub_settings_provider_);
+    settings_helper_.ReplaceProvider(kDeviceOwner);
 
     // Populate the stub DeviceSettingsProvider with valid values.
     SetDeviceSettings(false, "", false);
@@ -90,11 +77,6 @@ class UserManagerTest : public testing::Test {
     // Unregister the in-memory local settings instance.
     local_state_.reset();
 
-    // Restore the real DeviceSettingsProvider.
-    EXPECT_TRUE(
-      cros_settings_->RemoveSettingsProvider(&stub_settings_provider_));
-    cros_settings_->AddSettingsProvider(device_settings_provider_);
-
     // Shut down the DeviceSettingsService.
     DeviceSettingsService::Get()->UnsetSessionManager();
     TestingBrowserProcess::GetGlobal()->SetProfileManager(NULL);
@@ -140,14 +122,11 @@ class UserManagerTest : public testing::Test {
   void SetDeviceSettings(bool ephemeral_users_enabled,
                          const std::string &owner,
                          bool supervised_users_enabled) {
-    base::FundamentalValue
-        ephemeral_users_enabled_value(ephemeral_users_enabled);
-    stub_settings_provider_.Set(kAccountsPrefEphemeralUsersEnabled,
-        ephemeral_users_enabled_value);
-    base::StringValue owner_value(owner);
-    stub_settings_provider_.Set(kDeviceOwner, owner_value);
-    stub_settings_provider_.Set(kAccountsPrefSupervisedUsersEnabled,
-        base::FundamentalValue(supervised_users_enabled));
+    settings_helper_.SetBoolean(kAccountsPrefEphemeralUsersEnabled,
+                                ephemeral_users_enabled);
+    settings_helper_.SetString(kDeviceOwner, owner);
+    settings_helper_.SetBoolean(kAccountsPrefSupervisedUsersEnabled,
+                                supervised_users_enabled);
   }
 
   void RetrieveTrustedDevicePolicies() {
@@ -157,14 +136,9 @@ class UserManagerTest : public testing::Test {
  protected:
   content::TestBrowserThreadBundle thread_bundle_;
 
-  CrosSettings* cros_settings_;
-  CrosSettingsProvider* device_settings_provider_;
-  StubCrosSettingsProvider stub_settings_provider_;
+  ScopedCrosSettingsTestHelper settings_helper_;
   scoped_ptr<ScopedTestingLocalState> local_state_;
 
-  ScopedTestDeviceSettingsService test_device_settings_service_;
-  ScopedTestCrosSettings test_cros_settings_;
-
   scoped_ptr<ScopedUserManagerEnabler> user_manager_enabler_;
   base::ScopedTempDir temp_dir_;
 };