chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.h - Issue 1019283004: Switch to direct use of OwnerSettingsServiceChromeOS::Set() in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.h

Issue 1019283004: Switch to direct use of OwnerSettingsServiceChromeOS::Set() in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/system_tray_delegate_chromeos.cc ('K') | « chrome/browser/ui/ash/system_tray_delegate_chromeos.cc ('k') | chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.h

diff --git a/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.h b/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.h

index 23df3a1450304eef77346f168f71b39138334e39..19f5be28540459b4c6da635baab2693f1344bb67 100644

--- a/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.h

+++ b/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.h

@@ -25,11 +25,12 @@ class WebUIDataSource;

namespace chromeos {

class KioskAppManager;

+class OwnerSettingsServiceChromeOS;

class KioskAppsHandler : public content::WebUIMessageHandler,

public KioskAppManagerObserver {

public:

- KioskAppsHandler();

+ explicit KioskAppsHandler(OwnerSettingsServiceChromeOS* service);

~KioskAppsHandler() override;

void GetLocalizedValues(content::WebUIDataSource* source);

@@ -69,6 +70,7 @@ class KioskAppsHandler : public content::WebUIMessageHandler,

bool initialized_;

bool is_kiosk_enabled_;

bool is_auto_launch_enabled_;

+ OwnerSettingsServiceChromeOS* owner_settings_service_;

bartfab (slow) 2015/04/10 08:38:14 Nit: Const pointer.

Ivan Podogov 2015/04/10 09:50:53 Done.

base::WeakPtrFactory<KioskAppsHandler> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(KioskAppsHandler);