Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: chrome/browser/chromeos/login/kiosk_browsertest.cc

Issue 1019283004: Switch to direct use of OwnerSettingsServiceChromeOS::Set() in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use settings provider to set read-only device settings. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/kiosk_browsertest.cc
diff --git a/chrome/browser/chromeos/login/kiosk_browsertest.cc b/chrome/browser/chromeos/login/kiosk_browsertest.cc
index 890a1b7f17fad43bc683b178fb587a483f8c27d0..9a4af9ce8aec496a0000a498c23a7084b80c62e5 100644
--- a/chrome/browser/chromeos/login/kiosk_browsertest.cc
+++ b/chrome/browser/chromeos/login/kiosk_browsertest.cc
@@ -35,6 +35,7 @@
#include "chrome/browser/chromeos/login/users/mock_user_manager.h"
#include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
#include "chrome/browser/chromeos/login/wizard_controller.h"
+#include "chrome/browser/chromeos/ownership/fake_owner_settings_service.h"
#include "chrome/browser/chromeos/policy/device_policy_cros_browser_test.h"
#include "chrome/browser/chromeos/policy/proto/chrome_device_policy.pb.h"
#include "chrome/browser/chromeos/profiles/profile_helper.h"
@@ -500,6 +501,8 @@ class KioskTest : public OobeBaseTest {
// Needed to avoid showing Gaia screen instead of owner signin for
// consumer network down test cases.
StartupUtils::MarkDeviceRegistered(base::Closure());
+ owner_settings_service_.reset(new chromeos::FakeOwnerSettingsService(
+ ProfileManager::GetPrimaryUserProfile()));
}
void TearDownOnMainThread() override {
@@ -530,8 +533,9 @@ class KioskTest : public OobeBaseTest {
SetupTestAppUpdateCheck();
// Remove then add to ensure NOTIFICATION_KIOSK_APPS_LOADED fires.
- KioskAppManager::Get()->RemoveApp(test_app_id_);
- KioskAppManager::Get()->AddApp(test_app_id_);
+ KioskAppManager::Get()->RemoveApp(test_app_id_,
+ owner_settings_service_.get());
+ KioskAppManager::Get()->AddApp(test_app_id_, owner_settings_service_.get());
}
void FireKioskAppSettingsChanged() {
@@ -548,8 +552,9 @@ class KioskTest : public OobeBaseTest {
void ReloadAutolaunchKioskApps() {
SetupTestAppUpdateCheck();
- KioskAppManager::Get()->AddApp(test_app_id_);
- KioskAppManager::Get()->SetAutoLaunchApp(test_app_id_);
+ KioskAppManager::Get()->AddApp(test_app_id_, owner_settings_service_.get());
+ KioskAppManager::Get()->SetAutoLaunchApp(test_app_id_,
+ owner_settings_service_.get());
}
void StartUIForAppLaunch() {
@@ -793,6 +798,8 @@ class KioskTest : public OobeBaseTest {
use_consumer_kiosk_mode_ = use;
}
+ scoped_ptr<chromeos::FakeOwnerSettingsService> owner_settings_service_;
+
private:
bool use_consumer_kiosk_mode_;
std::string test_app_id_;

Powered by Google App Engine
This is Rietveld 408576698