Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/browser/ui/ash/system_tray_delegate_chromeos.cc

Issue 1019283004: Switch to direct use of OwnerSettingsServiceChromeOS::Set() in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rearrange device settings list. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
diff --git a/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc b/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
index 27ea957f9d7054eda6300787408748278e5d7642..f433202b234e7adb63dd3ab96e4cba3f191d5853 100644
--- a/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
+++ b/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
@@ -57,6 +57,8 @@
#include "chrome/browser/chromeos/login/users/chrome_user_manager.h"
#include "chrome/browser/chromeos/login/users/supervised_user_manager.h"
#include "chrome/browser/chromeos/options/network_config_view.h"
+#include "chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h"
+#include "chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h"
#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
#include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"
#include "chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.h"
@@ -1011,8 +1013,14 @@ void SystemTrayDelegateChromeOS::UpdateClockType() {
GetSystemTrayNotifier()->NotifyDateFormatChanged();
// This also works for enterprise-managed devices because they never have
// local owner.
- if (user_manager::UserManager::Get()->IsCurrentUserOwner())
- CrosSettings::Get()->SetBoolean(kSystemUse24HourClock, use_24_hour_clock);
+ if (user_manager::UserManager::Get()->IsCurrentUserOwner()) {
+ user_manager::User* user =
+ user_manager::UserManager::Get()->GetActiveUser();
+ Profile* profile = ProfileHelper::Get()->GetProfileByUser(user);
Mattias Nissler (ping if slow) 2015/03/27 12:42:06 Might be simpler to use ProfileManager::GetActiveU
Ivan Podogov 2015/03/27 12:51:14 Hm... Yes, it would probably be better. Maybe I sh
+ OwnerSettingsServiceChromeOS* service =
+ OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile);
+ service->SetBoolean(kSystemUse24HourClock, use_24_hour_clock);
+ }
}
void SystemTrayDelegateChromeOS::UpdateShowLogoutButtonInTray() {
@@ -1113,8 +1121,12 @@ void SystemTrayDelegateChromeOS::LoggedInStateChanged() {
// user's profile has actually been loaded (http://crbug.com/317745). The
// system tray's time format is updated at login via SetProfile().
if (user_manager::UserManager::Get()->IsCurrentUserOwner()) {
- CrosSettings::Get()->SetBoolean(kSystemUse24HourClock,
- ShouldUse24HourClock());
+ user_manager::User* user =
+ user_manager::UserManager::Get()->GetActiveUser();
+ Profile* profile = ProfileHelper::Get()->GetProfileByUser(user);
Mattias Nissler (ping if slow) 2015/03/27 12:42:06 ditto
+ OwnerSettingsServiceChromeOS* service =
+ OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile);
+ service->SetBoolean(kSystemUse24HourClock, ShouldUse24HourClock());
}
}

Powered by Google App Engine
This is Rietveld 408576698