Switch to direct use of OwnerSettingsServiceChromeOS::Set() in tests.

chrome/browser/chromeos/settings/shutdown_policy_handler_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/shutdown_policy_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
-#include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"

[bartfab (slow), 2015/03/31 14:12:41]

Nit: No longer used.

 #include "base/run_loop.h"
 #include "base/values.h"

[bartfab (slow), 2015/03/31 14:12:41]

Nit: No longer used.

-#include "chrome/browser/chromeos/settings/device_settings_service.h"
-#include "chromeos/chromeos_switches.h"
+#include "chrome/browser/chromeos/settings/settings_provider_test_base.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/settings/cros_settings_names.h"
-#include "chromeos/settings/cros_settings_provider.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 
 class ShutdownPolicyHandlerTest : public testing::Test,
+                                  public SettingsProviderTestBase,
                                   public ShutdownPolicyHandler::Delegate {
  public:
   void ResultCallback(bool reboot_on_shutdown) {
     reboot_on_shutdown_ = reboot_on_shutdown;
     callback_called_ = true;
   }
 
  protected:
   ShutdownPolicyHandlerTest()
-      : cros_settings_(nullptr),
-        callback_called_(false),
+      : callback_called_(false),
         reboot_on_shutdown_(false),
-        delegate_invocations_count_(0) {
-    base::CommandLine::ForCurrentProcess()->AppendSwitch(
-        switches::kStubCrosSettings);
-    test_cros_settings_.reset(new ScopedTestCrosSettings);
-}
+        delegate_invocations_count_(0) {}
 
   // testing::Test:
-void SetUp() override {
+  void SetUp() override {
     testing::Test::SetUp();
-    cros_settings_ = CrosSettings::Get();
     DBusThreadManager::Initialize();
+    ReplaceProvider(kRebootOnShutdown);
   }
 
-  void TearDown() override { DBusThreadManager::Shutdown(); }
+  void TearDown() override {
+    DBusThreadManager::Shutdown();
+    RestoreProvider();
+  }
 
   void SetRebootOnShutdown(bool reboot_on_shutdown) {
-    const base::FundamentalValue reboot_on_shutdown_value(reboot_on_shutdown);
-    CrosSettings::Get()
-        ->GetProvider(kRebootOnShutdown)
-        ->Set(kRebootOnShutdown, reboot_on_shutdown_value);
+    stub_settings_provider_.SetBoolean(kRebootOnShutdown, reboot_on_shutdown);

[bartfab (slow), 2015/03/31 14:12:41]

Nit: #include "chrome/browser/chromeos/settings/stub_cros_settings_provider.h"

     base::RunLoop().RunUntilIdle();
   }
 
   // ShutdownPolicyHandler::Delegate:
   void OnShutdownPolicyChanged(bool reboot_on_shutdown) override {
     reboot_on_shutdown_ = reboot_on_shutdown;
     delegate_invocations_count_++;
   }
 
  protected:
   content::TestBrowserThreadBundle thread_bundle_;
-
-  CrosSettings* cros_settings_;
-  scoped_ptr<CrosSettingsProvider> device_settings_provider_;
-
-  ScopedTestDeviceSettingsService test_device_settings_service_;
-  scoped_ptr<ScopedTestCrosSettings> test_cros_settings_;
-
   bool callback_called_;
   bool reboot_on_shutdown_;
   int delegate_invocations_count_;
 };
 
 TEST_F(ShutdownPolicyHandlerTest, RetrieveTrustedDevicePolicies) {
-  ShutdownPolicyHandler shutdown_policy_observer(cros_settings_, this);
+  ShutdownPolicyHandler shutdown_policy_observer(CrosSettings::Get(), this);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(0, delegate_invocations_count_);
 
   SetRebootOnShutdown(true);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(1, delegate_invocations_count_);
   EXPECT_TRUE(reboot_on_shutdown_);
 
   SetRebootOnShutdown(false);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(2, delegate_invocations_count_);
   EXPECT_FALSE(reboot_on_shutdown_);
 
   shutdown_policy_observer.Shutdown();
 
   SetRebootOnShutdown(true);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(2, delegate_invocations_count_);
   EXPECT_FALSE(reboot_on_shutdown_);
 }
 
 TEST_F(ShutdownPolicyHandlerTest, CheckIfRebootOnShutdown) {
-  ShutdownPolicyHandler shutdown_policy_observer(cros_settings_, this);
+  ShutdownPolicyHandler shutdown_policy_observer(CrosSettings::Get(), this);
   base::RunLoop().RunUntilIdle();
 
   // Allow shutdown.
   SetRebootOnShutdown(true);
   callback_called_ = false;
   shutdown_policy_observer.CheckIfRebootOnShutdown(
       base::Bind(&ShutdownPolicyHandlerTest::ResultCallback,
                  base::Unretained(this)));
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(callback_called_);
   EXPECT_TRUE(reboot_on_shutdown_);
   // Forbid shutdown.
   SetRebootOnShutdown(false);
   callback_called_ = false;
   shutdown_policy_observer.CheckIfRebootOnShutdown(
       base::Bind(&ShutdownPolicyHandlerTest::ResultCallback,
                  base::Unretained(this)));
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(callback_called_);
   EXPECT_FALSE(reboot_on_shutdown_);
 }
 
 }  // namespace chromeos