Chromevox2: make sure the braille cursor is shown for empty text fields.

chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Provides output services for ChromeVox.
  */
 
 goog.provide('Output');
 goog.provide('Output.EventType');
@@ skipping 313 matching lines @@
       actions.forEach(function(a) {
         a.run();
       });
     }
 
     // Braille.
     var selSpan =
         this.brailleBuffer_.getSpanInstanceOf(Output.SelectionSpan);
     var startIndex = -1, endIndex = -1;
     if (selSpan) {
-      var valueStart = this.brailleBuffer_.getSpanStart(selSpan);
-      var valueEnd = this.brailleBuffer_.getSpanEnd(selSpan);
-      if (valueStart === undefined || valueEnd === undefined) {
-        valueStart = -1;
-        valueEnd = -1;
-      } else {
-        startIndex = valueStart + selSpan.startIndex;
-        endIndex = valueStart + selSpan.endIndex;
-        this.brailleBuffer_.setSpan(new cvox.ValueSpan(valueStart),
-                                    valueStart, valueEnd);
-        this.brailleBuffer_.setSpan(new cvox.ValueSelectionSpan(),
-                                    startIndex, endIndex);
-      }
+      // Casts ok, since the span is known to be in the spannable.
+      var valueStart =
+          /** @type {number} */ (this.brailleBuffer_.getSpanStart(selSpan));
+      var valueEnd =
+          /** @type {number} */ (this.brailleBuffer_.getSpanEnd(selSpan));
+      startIndex = valueStart + selSpan.startIndex;
+      endIndex = valueStart + selSpan.endIndex;
+      this.brailleBuffer_.setSpan(new cvox.ValueSpan(0),
+                                  valueStart, valueEnd);
+      this.brailleBuffer_.setSpan(new cvox.ValueSelectionSpan(),
+                                  startIndex, endIndex);
     }
 
     var output = new cvox.NavBraille({
       text: this.brailleBuffer_,
       startIndex: startIndex,
       endIndex: endIndex
     });
 
     if (this.brailleBuffer_)
       cvox.ChromeVox.braille.write(output);
@@ skipping 68 matching lines @@
         return;
 
       // All possible tokens based on prefix.
       if (prefix == '$') {
         options.annotation = token;
         if (token == 'role') {
           // Non-localized role and state obtained by default.
           this.addToSpannable_(buff, node.role, options);
         } else if (token == 'value') {
           var text = node.attributes.value;
-          if (text) {
+          if (text !== undefined) {
             var offset = buff.getLength();
             if (node.attributes.textSelStart !== undefined) {
               options.annotation = new Output.SelectionSpan(
                   node.attributes.textSelStart,
                   node.attributes.textSelEnd);
             }
           } else if (node.role == chrome.automation.RoleType.staticText) {
             // TODO(dtseng): Remove once Blink treats staticText values as
             // names.
             text = node.attributes.name;
@@ skipping 285 matching lines @@
     }
 
     if (currentNode != root)
       throw 'Unbalanced parenthesis.';
 
     return root;
   }
 };
 
 });  // goog.scope