Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 1019283003: Chromevox2: make sure the braille cursor is shown for empty text fields. (Closed)

Created:
5 years, 9 months ago by Peter Lundblad
Modified:
5 years, 9 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromevox2: make sure the braille cursor is shown for empty text fields. The empty string in a boolean context led to the cursor not being shown. Changed to compare against undefined instead. This also fixes the value start offset to always be 0. It should only be non-zero for multiline text fields where only part of the field is included in the braille output. BUG= Committed: https://crrev.com/60383b1f0112b73aa4ab0d52ab053924c7927481 Cr-Commit-Position: refs/heads/master@{#321543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 2 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Lundblad
5 years, 9 months ago (2015-03-19 15:17:22 UTC) #2
David Tseng
lgtm
5 years, 9 months ago (2015-03-19 17:13:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019283003/1
5 years, 9 months ago (2015-03-20 10:03:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 10:31:54 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 10:32:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60383b1f0112b73aa4ab0d52ab053924c7927481
Cr-Commit-Position: refs/heads/master@{#321543}

Powered by Google App Engine
This is Rietveld 408576698