Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: src/messages.js

Issue 1019283002: [strong] Check constructor returns (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parser.cc » ('j') | test/cctest/test-parsing.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.js
diff --git a/src/messages.js b/src/messages.js
index 5c5e2075c151c91dcd97ac722b866b92d41947c0..e46979acf8fc9ee66870e86810804ce814bb4cca 100644
--- a/src/messages.js
+++ b/src/messages.js
@@ -173,6 +173,8 @@ var kMessages = {
strong_super_call_missing: ["Please always invoke the super constructor in subclasses in strong mode"],
strong_super_call_duplicate: ["Please don't invoke the super constructor multiple times in strong mode"],
strong_super_call_nested: ["Please don't invoke the super constructor nested inside another statement or expression in strong mode"],
+ strong_constructor_return_value: ["Please do not return a value from a constructor in strong mode"],
Dmitry Lomov (no reviews) 2015/03/19 13:59:41 Why do we keep pleading with users here?
adamk 2015/03/19 14:04:11 Drive-by +1 here. The "please" sounds odd for some
rossberg 2015/03/19 16:02:57 Strong mode intentionally has the mostly friendly
+ strong_constructor_return_misplaced: ["Please do not return from a constructor before its super constructor invocation in strong mode"],
sloppy_lexical: ["Block-scoped declarations (let, const, function, class) not yet supported outside strict mode"],
malformed_arrow_function_parameter_list: ["Malformed arrow function parameter list"],
generator_poison_pill: ["'caller' and 'arguments' properties may not be accessed on generator functions."],
« no previous file with comments | « no previous file | src/parser.cc » ('j') | test/cctest/test-parsing.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698