Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1019253002: Support 'First-Party-Only' cookies in devtools. (Closed)

Created:
5 years, 9 months ago by Mike West
Modified:
5 years, 9 months ago
Reviewers:
eustas, pfeldman
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Support 'First-Party-Only' cookies in devtools. This patch adds a 'first-party' column to the cookies table of devtools' network panel, and adjusts the cookie parser to support the new attribute. BUG=459154 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -30 lines) Patch
M LayoutTests/inspector/cookie-parser.html View 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/inspector/cookie-parser-expected.txt View 3 chunks +34 lines, -27 lines 0 comments Download
M LayoutTests/inspector/cookie-resource-match.html View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/components_lazy/CookiesTable.js View 4 chunks +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/CookieParser.js View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mike West
eustas@, pfeldman@: Would one of you mind taking a look at this patch to support ...
5 years, 9 months ago (2015-03-19 09:47:24 UTC) #2
pfeldman
Please provide a screenshot in the bug.
5 years, 9 months ago (2015-03-19 09:48:14 UTC) #3
Mike West
On 2015/03/19 at 09:48:14, pfeldman wrote: > Please provide a screenshot in the bug. https://chromium.googlecode.com/issues/attachment?aid=4591540004000&name=Screenshot+from+2015-03-19+11%3A29%3A48.png&token=ABZ6GAd2L80AE2yaRipug-uGJWY435cwWQ%3A1426761036399&inline=1 ...
5 years, 9 months ago (2015-03-19 10:31:24 UTC) #4
pfeldman
lgtm
5 years, 9 months ago (2015-03-19 17:17:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019253002/1
5 years, 9 months ago (2015-03-19 17:22:01 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 17:26:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192181

Powered by Google App Engine
This is Rietveld 408576698