Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1019243002: Serializer: reorder root list items. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
mvstanton, Erik Corry
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer: reorder root list items. The first 32 root list items can be encoded very efficiently. By reordering, we can better encode some often referenced root objects. R=mvstanton@chromium.org Committed: https://crrev.com/4ddeac6cd7ec6e0242fd8314a02e62e5e74ff457 Cr-Commit-Position: refs/heads/master@{#27293}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/heap/heap.h View 4 chunks +9 lines, -9 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 9 months ago (2015-03-19 09:09:47 UTC) #1
mvstanton
lgtm
5 years, 9 months ago (2015-03-19 09:11:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019243002/1
5 years, 9 months ago (2015-03-19 09:11:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 09:33:53 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4ddeac6cd7ec6e0242fd8314a02e62e5e74ff457 Cr-Commit-Position: refs/heads/master@{#27293}
5 years, 9 months ago (2015-03-19 09:34:11 UTC) #6
Erik Corry
5 years, 9 months ago (2015-03-19 12:14:06 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/1019243002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1019243002/diff/1/src/heap/heap.h#newcode57
src/heap/heap.h:57: V(Map, cons_one_byte_string_map, ConsOneByteStringMap)      
                \
If these are frequent in the snapshot perhaps we should be flattening strings
before generating the snapshot.

Powered by Google App Engine
This is Rietveld 408576698