Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1019213003: Instrumented libraries: add a script to build/package binaries. (Closed)

Created:
5 years, 9 months ago by earthdok
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: add a script to build/package binaries. BUG=462636 R=glider@chromium.org NOTRY=true Committed: https://crrev.com/b251b58b4c97a520b29269c84895a5423736346c Cr-Commit-Position: refs/heads/master@{#322149}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : add no-origins #

Total comments: 4

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
A third_party/instrumented_libraries/scripts/build_and_package.sh View 1 2 3 4 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
earthdok
5 years, 9 months ago (2015-03-23 13:36:28 UTC) #1
earthdok
On 2015/03/23 13:36:28, earthdok wrote: there are a couple problems with this script: - this ...
5 years, 9 months ago (2015-03-23 16:04:37 UTC) #2
earthdok
ptal
5 years, 9 months ago (2015-03-24 18:03:27 UTC) #3
Alexander Potapenko
lgtm https://codereview.chromium.org/1019213003/diff/60001/third_party/instrumented_libraries/scripts/build_and_package.sh File third_party/instrumented_libraries/scripts/build_and_package.sh (right): https://codereview.chromium.org/1019213003/diff/60001/third_party/instrumented_libraries/scripts/build_and_package.sh#newcode53 third_party/instrumented_libraries/scripts/build_and_package.sh:53: echo upload_to_google_storage.py -b chromium-instrumented-libraries ${archive_name}.tgz Mind the line ...
5 years, 9 months ago (2015-03-25 13:10:34 UTC) #4
earthdok
also: added -j, tweaked the output directory name https://codereview.chromium.org/1019213003/diff/60001/third_party/instrumented_libraries/scripts/build_and_package.sh File third_party/instrumented_libraries/scripts/build_and_package.sh (right): https://codereview.chromium.org/1019213003/diff/60001/third_party/instrumented_libraries/scripts/build_and_package.sh#newcode53 third_party/instrumented_libraries/scripts/build_and_package.sh:53: echo ...
5 years, 9 months ago (2015-03-25 13:24:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019213003/60001
5 years, 9 months ago (2015-03-25 13:25:23 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-25 13:26:11 UTC) #8
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/b251b58b4c97a520b29269c84895a5423736346c Cr-Commit-Position: refs/heads/master@{#322149}
5 years, 9 months ago (2015-03-25 13:26:34 UTC) #9
earthdok
5 years, 9 months ago (2015-03-25 13:27:07 UTC) #10
Message was sent while issue was closed.
On 2015/03/25 13:26:11, I haz the power (commit-bot) wrote:
> Committed patchset #4 (id:60001)

Damn, I thought I'd already uploaded PS#5. I'll submit it separately.

Powered by Google App Engine
This is Rietveld 408576698