Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1019193002: Fix for handling alt+Left Arrow key for moving to previous visited URL. (Closed)

Created:
5 years, 9 months ago by Deepak
Modified:
5 years, 9 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for handling alt+Left Arrow key for moving to previous visited URL. currently behavior of alt+Left arrow key and Left Arrow key are same. Check added so that when user select alt+Left arrow key then it will be handled by default behavior. BUG=468605 Committed: https://crrev.com/20ff333d6d95a00e8b203a501781aa8481127493 Cr-Commit-Position: refs/heads/master@{#321516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/webui/resources/js/cr/ui/focus_row.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Deepak
@dbeam PTAL at small change for handling alt+Left arrow key for moving to the previous ...
5 years, 9 months ago (2015-03-19 04:55:29 UTC) #2
Dan Beam
+hcarmona
5 years, 9 months ago (2015-03-19 19:51:56 UTC) #4
hcarmona
lgtm
5 years, 9 months ago (2015-03-19 20:24:12 UTC) #5
Dan Beam
lgtm
5 years, 9 months ago (2015-03-19 20:43:54 UTC) #6
Deepak
On 2015/03/19 20:43:54, Dan Beam wrote: > lgtm Thankyou Hactor and Dan for review.
5 years, 9 months ago (2015-03-20 02:47:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019193002/1
5 years, 9 months ago (2015-03-20 02:47:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 04:30:23 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 04:31:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20ff333d6d95a00e8b203a501781aa8481127493
Cr-Commit-Position: refs/heads/master@{#321516}

Powered by Google App Engine
This is Rietveld 408576698