third_party/mojo_services/src/view_manager/public/cpp/tests/view_unittest.cc - Issue 1019173002: Update mojo sdk to rev 7214b7ec7d27563b2666afad86cf1c5895c56c18

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo_services/src/view_manager/public/cpp/tests/view_unittest.cc

Issue 1019173002: Update mojo sdk to rev 7214b7ec7d27563b2666afad86cf1c5895c56c18 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keep permission service alive if embedder drops requests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo_services/src/surfaces/public/interfaces/surfaces.mojom ('k') | third_party/mojo_services/src/view_manager/public/cpp/view_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo_services/src/view_manager/public/cpp/tests/view_unittest.cc

diff --git a/third_party/mojo_services/src/view_manager/public/cpp/tests/view_unittest.cc b/third_party/mojo_services/src/view_manager/public/cpp/tests/view_unittest.cc

index abbd71255c2cc41f23c76a5b4d1f40d65f84e9a0..09d1bde6077a364766dfc31c37b3ef5c67a29f81 100644

--- a/third_party/mojo_services/src/view_manager/public/cpp/tests/view_unittest.cc

+++ b/third_party/mojo_services/src/view_manager/public/cpp/tests/view_unittest.cc

@@ -742,7 +742,7 @@ class SharedPropertyChangeObserver : public ViewObserver {

explicit SharedPropertyChangeObserver(View* view) : view_(view) {

view_->AddObserver(this);

}

- virtual ~SharedPropertyChangeObserver() { view_->RemoveObserver(this); }

+ ~SharedPropertyChangeObserver() override { view_->RemoveObserver(this); }

Changes GetAndClearChanges() {

Changes changes;

@@ -835,7 +835,7 @@ class LocalPropertyChangeObserver : public ViewObserver {

old_property_value_(-1) {

view_->AddObserver(this);

}

- virtual ~LocalPropertyChangeObserver() { view_->RemoveObserver(this); }

+ ~LocalPropertyChangeObserver() override { view_->RemoveObserver(this); }

PropertyChangeInfo PropertyChangeInfoAndClear() {

PropertyChangeInfo result(property_key_, old_property_value_);