third_party/mojo/src/mojo/public/cpp/bindings/binding.h - Issue 1019173002: Update mojo sdk to rev 7214b7ec7d27563b2666afad86cf1c5895c56c18

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/cpp/bindings/binding.h

Issue 1019173002: Update mojo sdk to rev 7214b7ec7d27563b2666afad86cf1c5895c56c18 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keep permission service alive if embedder drops requests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/cpp/application/lib/application_test_base.cc ('k') | third_party/mojo/src/mojo/public/cpp/bindings/lib/router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/cpp/bindings/binding.h

diff --git a/third_party/mojo/src/mojo/public/cpp/bindings/binding.h b/third_party/mojo/src/mojo/public/cpp/bindings/binding.h

index db5e96d911336308ea05676cae5a93dec6da8f4e..a982bdbd4b10642837f8e1306253f0832f43e95b 100644

--- a/third_party/mojo/src/mojo/public/cpp/bindings/binding.h

+++ b/third_party/mojo/src/mojo/public/cpp/bindings/binding.h

@@ -101,7 +101,7 @@ class Binding : public ErrorHandler {

// implementation unbound.

~Binding() override {

if (internal_router_) {

- DestroyRouter();

+ Close();

}

@@ -169,6 +169,8 @@ class Binding : public ErrorHandler {

InterfaceRequest<Interface> request =

MakeRequest<Interface>(internal_router_->PassMessagePipe());

DestroyRouter();

+ // TODO(vtl): The |.Pass()| below is only needed due to an MSVS bug; remove

+ // it once that's fixed.

return request.Pass();

}