Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: content/browser/renderer_host/input/mouse_wheel_rails_filter_mac.cc

Issue 1019153002: Mac: Add rails for scrolling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/fabsf/std::abs/g Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/mouse_wheel_rails_filter_mac.cc
diff --git a/content/browser/renderer_host/input/mouse_wheel_rails_filter_mac.cc b/content/browser/renderer_host/input/mouse_wheel_rails_filter_mac.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3681ba9ba67093677dace77442e2ca8580e8e592
--- /dev/null
+++ b/content/browser/renderer_host/input/mouse_wheel_rails_filter_mac.cc
@@ -0,0 +1,38 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/renderer_host/input/mouse_wheel_rails_filter_mac.h"
+
+using blink::WebInputEvent;
+using blink::WebMouseWheelEvent;
+
+namespace content {
+
+MouseWheelRailsFilterMac::MouseWheelRailsFilterMac() {
+}
+
+MouseWheelRailsFilterMac::~MouseWheelRailsFilterMac() {
+}
+
+WebInputEvent::RailsMode MouseWheelRailsFilterMac::UpdateRailsMode(
+ const WebMouseWheelEvent& event) {
+ // A somewhat-arbitrary decay constant for hysteresis.
+ const float kDecayConstant = 0.8f;
+
+ if (event.phase == WebMouseWheelEvent::PhaseBegan) {
+ decayed_delta_ = gfx::Vector2dF();
+ }
+ if (event.deltaX == 0 && event.deltaY == 0)
+ return WebInputEvent::RailsModeFree;
+
+ decayed_delta_.Scale(kDecayConstant);
+ decayed_delta_ +=
+ gfx::Vector2dF(std::abs(event.deltaX), std::abs(event.deltaY));
+
+ if (decayed_delta_.y() >= decayed_delta_.x())
tdresser 2015/03/19 13:03:40 Do we want to rail this aggressively? This makes d
ccameron 2015/03/19 19:33:14 Exactly. This mirrors the behavior that Safari has
tdresser 2015/03/19 20:57:51 Yikes. I just tried it out on Safari - can't say I
+ return WebInputEvent::RailsModeVertical;
+ return WebInputEvent::RailsModeHorizontal;
+}
+
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698