Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 1019133002: Enable WebNavigationApiTest.CrossProcess (Closed)

Created:
5 years, 9 months ago by nasko
Modified:
5 years, 9 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable WebNavigationApiTest.CrossProcess This CL enables the WebNavigationApiTest.CrossProcess test, but disables the crossProcessWithSameSiteCommit subtest, since it is flaky due to imprecise ordering of navigation events. BUG=467800 Committed: https://crrev.com/2e41145abd02c974584bc8c837477169ee1464d0 Cr-Commit-Position: refs/heads/master@{#321375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/crossProcess/test_crossProcess.js View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nasko
Hey Charlie, Can you review this CL for me? It disables one of the cross-process ...
5 years, 9 months ago (2015-03-18 22:09:43 UTC) #2
Charlie Reis
LGTM
5 years, 9 months ago (2015-03-19 16:24:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019133002/1
5 years, 9 months ago (2015-03-19 16:25:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 16:43:54 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 16:44:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e41145abd02c974584bc8c837477169ee1464d0
Cr-Commit-Position: refs/heads/master@{#321375}

Powered by Google App Engine
This is Rietveld 408576698