Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1019123003: [Metrics] Fix presubmit scripts to return an error code on failure. (Closed)

Created:
5 years, 9 months ago by Ilya Sherman
Modified:
5 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, Steven Holte
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Metrics] Fix presubmit scripts to set an error exit code on failure. Due to a bug in a recent refactoring, the script would log an error to the console, but would still set the success exit code, 0. BUG=468523 TEST=Try to submit a CL with invalid formatting, the presubmit script should block submission. R=asvitkine@chromium.org Committed: https://crrev.com/385bc2ca9d49328c27f1af967b16439acaa44817 Cr-Commit-Position: refs/heads/master@{#321436}

Patch Set 1 #

Patch Set 2 : Actually set the exit code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/metrics/common/presubmit_util.py View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ilya Sherman
5 years, 9 months ago (2015-03-18 23:11:23 UTC) #2
Mark P
lgtm
5 years, 9 months ago (2015-03-19 18:52:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019123003/10005
5 years, 9 months ago (2015-03-19 21:19:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:10005)
5 years, 9 months ago (2015-03-19 21:43:02 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 21:43:56 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/385bc2ca9d49328c27f1af967b16439acaa44817
Cr-Commit-Position: refs/heads/master@{#321436}

Powered by Google App Engine
This is Rietveld 408576698