 Chromium Code Reviews
 Chromium Code Reviews Issue 
            1019123003:
    [Metrics] Fix presubmit scripts to return an error code on failure.  (Closed)
    
  
    Issue 
            1019123003:
    [Metrics] Fix presubmit scripts to return an error code on failure.  (Closed) 
  | Description[Metrics] Fix presubmit scripts to set an error exit code on failure.
Due to a bug in a recent refactoring, the script would log an error to the
console, but would still set the success exit code, 0.
BUG=468523
TEST=Try to submit a CL with invalid formatting, the presubmit script should block submission.
R=asvitkine@chromium.org
Committed: https://crrev.com/385bc2ca9d49328c27f1af967b16439acaa44817
Cr-Commit-Position: refs/heads/master@{#321436}
   Patch Set 1 #Patch Set 2 : Actually set the exit code #Messages
    Total messages: 7 (2 generated)
     |