build/common.gypi - Issue 1019123002: Switch ChromeOS and ChromeCast to use external V8 snapshot files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1019123002: Switch ChromeOS and ChromeCast to use external V8 snapshot files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8_ext_chromeos

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index dccdfec64a8c4519dc918071f51200a6f98d084e..c57ede56ecb2625274cc8028a88feca3613099a1 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1022,9 +1022,8 @@

'optimize_jni_generation%': 0,

}],

- # TODO(rmcilroy): Enable v8_use_external_startup_data on ChromeOS

- # http://crbug.com/421063

- ['chromecast==0 and chromeos==0 and OS!="ios"', {

+ # TODO(rmcilroy): Remove ios check. http://crbug.com/421063.

+ ['OS!="ios"', {

'v8_use_external_startup_data%': 1,

}, {

'v8_use_external_startup_data%': 0,

« no previous file with comments | « no previous file | chrome/tools/build/chromeos/FILES.cfg » ('j') | no next file with comments »