Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1019083002: MIPS: Serializer: serialize internal references via object visitor. (Closed)

Created:
5 years, 9 months ago by balazs.kilvady
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Serializer: serialize internal references via object visitor. Port 7c149afb6c875b1c53723384459dc14a0e961927 BUG= Committed: https://crrev.com/bd885aa0f92148bbae63a0b7af83c1f1cdfe879d Cr-Commit-Position: refs/heads/master@{#27283}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -57 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 6 chunks +54 lines, -26 lines 1 comment Download
M src/mips64/assembler-mips64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 6 chunks +66 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 9 months ago (2015-03-18 20:41:08 UTC) #2
paul.l...
There are some issues here, cctest/test-serialize/SerializeInternalReference fails. But without this CL the build is broken ...
5 years, 9 months ago (2015-03-18 20:57:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019083002/1
5 years, 9 months ago (2015-03-18 20:58:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 21:41:34 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 21:41:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd885aa0f92148bbae63a0b7af83c1f1cdfe879d
Cr-Commit-Position: refs/heads/master@{#27283}

Powered by Google App Engine
This is Rietveld 408576698