CMake option to install utils, e.g. FileCheck

CMake option to install utils, e.g. FileCheck
The goal is to replace nacl tests' use of a hand-crafted filecheck
tool, with LLVM's FileCheck. To do so, we need to first ensure
FileCheck is copied to the install directory.

To that end, this CL introduces a build flag, LLVM_INSTALL_UTILS.

A separate CL enables this switch in toolchain_build_pnacl.py, see https://codereview.chromium.org/1018123002/

BUG=NONE
R=dschuff@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=1352ceb5438aa289b24f38dd5dda9900dd8b37f6

[Derek Schuff, 2015-03-18 21:53:32]

https://codereview.chromium.org/1019043002/diff/1/cmake/modules/AddLLVM.cmake
File cmake/modules/AddLLVM.cmake (right):

https://codereview.chromium.org/1019043002/diff/1/cmake/modules/AddLLVM.cmake...
cmake/modules/AddLLVM.cmake:505: RUNTIME DESTINATION utils)
will this install the utils into the "utils" directory? it looks like in
autoconf they go into the "bin" directory.

[Mircea Trofin, 2015-03-19 00:04:00]

https://codereview.chromium.org/1019043002/diff/1/cmake/modules/AddLLVM.cmake
File cmake/modules/AddLLVM.cmake (right):

https://codereview.chromium.org/1019043002/diff/1/cmake/modules/AddLLVM.cmake...
cmake/modules/AddLLVM.cmake:505: RUNTIME DESTINATION utils)
On 2015/03/18 21:53:32, Derek Schuff wrote:
> will this install the utils into the "utils" directory? it looks like in
> autoconf they go into the "bin" directory.

Done.

[Mircea Trofin, 2015-03-19 00:06:34]

Patchset #3 (id:40001) has been deleted

[Mircea Trofin, 2015-03-19 00:06:41]

Patchset #2 (id:20001) has been deleted

[Mircea Trofin, 2015-03-19 00:10:49]

Cleaned up the CLs

[Derek Schuff, 2015-03-19 00:15:13]

https://codereview.chromium.org/1019043002/diff/60001/cmake/modules/AddLLVM.c...
File cmake/modules/AddLLVM.cmake (right):

https://codereview.chromium.org/1019043002/diff/60001/cmake/modules/AddLLVM.c...
cmake/modules/AddLLVM.cmake:503: if( LLVM_INSTALL_UTILS )
do these variables have to get defaults anywhere? or will it just fail if you
don't have -{D,U}LLVM_INSTALL_UTILS on the command line?

[Mircea Trofin, 2015-03-19 00:29:46]

https://codereview.chromium.org/1019043002/diff/60001/cmake/modules/AddLLVM.c...
File cmake/modules/AddLLVM.cmake (right):

https://codereview.chromium.org/1019043002/diff/60001/cmake/modules/AddLLVM.c...
cmake/modules/AddLLVM.cmake:503: if( LLVM_INSTALL_UTILS )
On 2015/03/19 00:15:13, Derek Schuff wrote:
> do these variables have to get defaults anywhere? or will it just fail if you
> don't have -{D,U}LLVM_INSTALL_UTILS on the command line?

Done. I added the documentation for the option, too, in the spirit of the other
options.

[Derek Schuff, 2015-03-19 16:08:11]

add LOCALMOD markers and LGTM. alternatively, and maybe even better, you could
send this upstream. There's active work going on to bring the cmake build to
parity with (and replace) autoconf, so I expect it would be well-received.

[Mircea Trofin, 2015-03-19 22:40:30]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2015-03-19 22:40:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dschuff@chromium.org
Link to the patchset: https://codereview.chromium.org/1019043002/#ps100001
(title: "Added LOCALMOD")

[Mircea Trofin, 2015-03-19 22:40:38]

The CQ bit was unchecked by mtrofin@chromium.org

[Mircea Trofin, 2015-03-19 22:41:45]

Committed patchset #4 (id:100001) manually as
1352ceb5438aa289b24f38dd5dda9900dd8b37f6 (presubmit successful).