RtcVideo{Encoder,Decoder}{Factory,} minor cleanup: consts, range based loops, comments.

content/renderer/media/rtc_video_encoder_factory.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/rtc_video_encoder_factory.h"
 
 #include "base/command_line.h"
 #include "content/common/gpu/client/gpu_video_encode_accelerator_host.h"
 #include "content/public/common/content_switches.h"
 #include "content/renderer/media/rtc_video_encoder.h"
 #include "media/renderers/gpu_video_accelerator_factories.h"
 #include "media/video/video_encode_accelerator.h"
 
 namespace content {
 
 namespace {
 
 // Translate from media::VideoEncodeAccelerator::SupportedProfile to
 // one or more instances of cricket::WebRtcVideoEncoderFactory::VideoCodec
 void VEAToWebRTCCodecs(
     std::vector<cricket::WebRtcVideoEncoderFactory::VideoCodec>* codecs,
     const media::VideoEncodeAccelerator::SupportedProfile& profile) {
-  int width = profile.max_resolution.width();
-  int height = profile.max_resolution.height();
-  int fps = profile.max_framerate_numerator;
+  const int width = profile.max_resolution.width();
+  const int height = profile.max_resolution.height();
+  const int fps = profile.max_framerate_numerator;
   DCHECK_EQ(profile.max_framerate_denominator, 1U);
 
   const base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess();
   if (profile.profile >= media::VP8PROFILE_MIN &&
       profile.profile <= media::VP8PROFILE_MAX) {
     codecs->push_back(cricket::WebRtcVideoEncoderFactory::VideoCodec(
         webrtc::kVideoCodecVP8, "VP8", width, height, fps));
   } else if (profile.profile >= media::H264PROFILE_MIN &&
              profile.profile <= media::H264PROFILE_MAX) {
     if (cmd_line->HasSwitch(switches::kEnableWebRtcHWH264Encoding)) {
       codecs->push_back(cricket::WebRtcVideoEncoderFactory::VideoCodec(
           webrtc::kVideoCodecH264, "H264", width, height, fps));
     }
   }
 }
 
 }  // anonymous namespace
 
 RTCVideoEncoderFactory::RTCVideoEncoderFactory(
     const scoped_refptr<media::GpuVideoAcceleratorFactories>& gpu_factories)
     : gpu_factories_(gpu_factories) {
-  std::vector<media::VideoEncodeAccelerator::SupportedProfile> profiles =
+  const std::vector<media::VideoEncodeAccelerator::SupportedProfile> profiles =

[emircan, 2015/03/19 01:16:55]

Consider assigning by reference to the rvalue to save from a copy:
const std::vector<media::VideoEncodeAccelerator::SupportedProfile>& profiles

[mcasas, 2015/03/19 02:54:26]

Done.

       gpu_factories_->GetVideoEncodeAcceleratorSupportedProfiles();
-  for (size_t i = 0; i < profiles.size(); ++i)
-    VEAToWebRTCCodecs(&codecs_, profiles[i]);
+  for (const auto& profile : profiles)
+    VEAToWebRTCCodecs(&codecs_, profile);
 }
 
 RTCVideoEncoderFactory::~RTCVideoEncoderFactory() {}
 
 webrtc::VideoEncoder* RTCVideoEncoderFactory::CreateVideoEncoder(
     webrtc::VideoCodecType type) {
-  bool found = false;
-  for (size_t i = 0; i < codecs_.size(); ++i) {
-    if (codecs_[i].type == type) {
-      found = true;
-      break;
-    }
+  for (const auto& codec : codecs_) {
+    if (codec.type == type)
+      return new RTCVideoEncoder(type, gpu_factories_);

[emircan, 2015/03/19 01:16:56]

Consider using std::find_if for clarity. 

[mcasas, 2015/03/19 02:54:25]

Hmm in this case and since VideoCodec does not have an
appropriate operator==, it turns out ugly(er):

std::vector<VideoCodec>::const_iterator it = std::find_if(
    codecs_.begin(), codecs_.end(),
    [type](const VideoCodec& codec) { return codec.type == type; });
if (it != codecs_.end())
  new RTCVideoEncoder(type, gpu_factories_);

So I'd rather leave it as it's now.

   }
-  if (!found)
-    return NULL;
-  return new RTCVideoEncoder(type, gpu_factories_);
+  return NULL;

[Pawel Osciak, 2015/03/19 01:26:33]

s/NULL/nullptr/

[mcasas, 2015/03/19 02:54:25]

Done.

 }
 
 const std::vector<cricket::WebRtcVideoEncoderFactory::VideoCodec>&
 RTCVideoEncoderFactory::codecs() const {
   return codecs_;
 }
 
 void RTCVideoEncoderFactory::DestroyVideoEncoder(
     webrtc::VideoEncoder* encoder) {
   delete encoder;
 }
 
 }  // namespace content