RtcVideo{Encoder,Decoder}{Factory,} minor cleanup: consts, range based loops, comments.

content/renderer/media/rtc_video_encoder.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_RTC_VIDEO_ENCODER_H_
 #define CONTENT_RENDERER_MEDIA_RTC_VIDEO_ENCODER_H_
 
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/thread_checker.h"
 #include "base/time/time.h"
 #include "content/common/content_export.h"
 #include "media/base/video_decoder_config.h"
 #include "third_party/webrtc/modules/video_coding/codecs/interface/video_codec_interface.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace base {
-

[Pawel Osciak, 2015/03/19 01:26:33]

Namespace formatting rule examples at
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespace_For...
show that empty lines should be there.

[mcasas, 2015/03/19 02:54:25]

Usually these namespace+forward declarations don't get
such treatment. Strange that is not mentioned in the 
G C++ StyleGuide nor in the Chromium one.

See for instance [1-4].

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/dbus/bus.h&sq=pack...
[2]
https://code.google.com/p/chromium/codesearch#chromium/src/ash/shell.h&sq=pac...
[3]
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/ren...
[4]
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/br...

 class MessageLoopProxy;
-
 }  // namespace base
 
 namespace media {
-
 class GpuVideoAcceleratorFactories;
-
 }  // namespace media
 
 namespace content {
 
 // RTCVideoEncoder uses a media::VideoEncodeAccelerator to implement a
 // webrtc::VideoEncoder class for WebRTC.  Internally, VEA methods are
 // trampolined to a private RTCVideoEncoder::Impl instance.  The Impl class runs
 // on the worker thread queried from the |gpu_factories_|, which is presently
 // the media thread.  RTCVideoEncoder is sychronized by webrtc::VideoSender.
 // webrtc::VideoEncoder methods do not run concurrently. RTCVideoEncoder is run
@@ skipping 38 matching lines @@
 
   void RecordInitEncodeUMA(int32_t init_retval,
                            media::VideoCodecProfile profile);
 
   base::ThreadChecker thread_checker_;
 
   // The video codec type, as reported to WebRTC.
   const webrtc::VideoCodecType video_codec_type_;
 
   // Factory for creating VEAs, shared memory buffers, etc.
-  scoped_refptr<media::GpuVideoAcceleratorFactories> gpu_factories_;
+  const scoped_refptr<media::GpuVideoAcceleratorFactories> gpu_factories_;
 
   // webrtc::VideoEncoder encode complete callback.
   webrtc::EncodedImageCallback* encoded_image_callback_;
 
   // The RTCVideoEncoder::Impl that does all the work.
   scoped_refptr<Impl> impl_;
 
   // We cannot immediately return error conditions to the WebRTC user of this
   // class, as there is no error callback in the webrtc::VideoEncoder interface.
   // Instead, we cache an error status here and return it the next time an
   // interface entry point is called.
   int32_t impl_status_;
 
   // Weak pointer factory for posting back VEA::Client notifications to
   // RTCVideoEncoder.
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<RTCVideoEncoder> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RTCVideoEncoder);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_RTC_VIDEO_ENCODER_H_