Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chromeos/network/onc/onc_validator_unittest.cc

Issue 1019033002: Add an ONC property for the third-party VPN provider extension ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed browser tests. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_validator_unittest.cc
diff --git a/chromeos/network/onc/onc_validator_unittest.cc b/chromeos/network/onc/onc_validator_unittest.cc
index add35723ae9ab0d3c63c96dfc394100aa795b1e1..8517f7175e09c77e1cefea802416580fdfec8ccd 100644
--- a/chromeos/network/onc/onc_validator_unittest.cc
+++ b/chromeos/network/onc/onc_validator_unittest.cc
@@ -208,6 +208,9 @@ INSTANTIATE_TEST_CASE_P(
false),
OncParams("openvpn_with_password.onc",
&kNetworkConfigurationSignature,
+ false),
+ OncParams("third_party_vpn.onc",
+ &kNetworkConfigurationSignature,
false)));
namespace {
@@ -348,6 +351,10 @@ INSTANTIATE_TEST_CASE_P(
std::make_pair(OncParams("openvpn-missing-verify-x509-name",
&kNetworkConfigurationSignature,
false),
+ ExpectStrictNotValid("")),
+ std::make_pair(OncParams("third-party-vpn-missing-extension-id",
+ &kNetworkConfigurationSignature,
+ false),
ExpectStrictNotValid(""))));
// Strict validator returns INVALID. Liberal validator repairs.
« no previous file with comments | « chromeos/network/onc/onc_validator.cc ('k') | chromeos/test/data/network/invalid_settings_with_repairs.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698