Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: chromeos/network/network_state.h

Issue 1019033002: Add an ONC property for the third-party VPN provider extension ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed browser tests. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state.h
diff --git a/chromeos/network/network_state.h b/chromeos/network/network_state.h
index c456909150bfa65d97a4f094acf2ae4adbdd4d61..e4d9cce2cc090a730d8431e11f259c54abfcb0c5 100644
--- a/chromeos/network/network_state.h
+++ b/chromeos/network/network_state.h
@@ -92,8 +92,11 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
const std::string& roaming() const { return roaming_; }
const std::string& payment_url() const { return payment_url_; }
bool cellular_out_of_credits() const { return cellular_out_of_credits_; }
- const std::string& vpn_provider_extension_id() const {
- return vpn_provider_extension_id_;
+
+ // VPN property accessors
+ const std::string& vpn_provider_type() const { return vpn_provider_type_; }
+ const std::string& third_party_vpn_provider_extension_id() const {
+ return third_party_vpn_provider_extension_id_;
}
// Returns true if |connection_state_| is a connected/connecting state.
@@ -183,10 +186,10 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
std::string payment_url_;
bool cellular_out_of_credits_;
- // VPN property. For networks using a third-party VPN provider, this will be
- // the provider's extension ID. For networks using the built-in OpenVPN and
- // L2TP support, this will be an empty string.
- std::string vpn_provider_extension_id_;
+ // VPN properties, used to construct the display name and to show the correct
+ // configuration dialog.
+ std::string vpn_provider_type_;
+ std::string third_party_vpn_provider_extension_id_;
// TODO(pneubeck): Remove this once (Managed)NetworkConfigurationHandler
// provides proxy configuration. crbug.com/241775
« no previous file with comments | « chrome/test/data/extensions/api_test/networking_private/chromeos/test.js ('k') | chromeos/network/network_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698