chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc - Issue 1019033002: Add an ONC property for the third-party VPN provider extension ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

Issue 1019033002: Add an ONC property for the third-party VPN provider extension ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed browser tests. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/system/chromeos/network/vpn_delegate.cc ('k') | chrome/test/data/extensions/api_test/networking_private/chromeos/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

index d9932356512bb53a5a4e83b66f7a05b9991829d5..021110ef55e8a3904ffecd33cb8c75b69daaa9c0 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

@@ -358,6 +358,15 @@ class NetworkingPrivateChromeOSApiTest : public ExtensionApiTest {

base::StringValue(shill::kProviderOpenVpn));

profile_test->AddService(kUser1ProfilePath, "stub_vpn1");

+ AddService("stub_vpn2", "vpn2", shill::kTypeVPN, shill::kStateOffline);

+ service_test_->SetServiceProperty(

+ "stub_vpn2", shill::kProviderTypeProperty,

+ base::StringValue(shill::kProviderThirdPartyVpn));

+ service_test_->SetServiceProperty(

+ "stub_vpn2", shill::kProviderHostProperty,

+ base::StringValue("third_party_provider_extension_id"));

+ profile_test->AddService(kUser1ProfilePath, "stub_vpn2");

content::RunAllPendingInMessageLoop();

}